Re: .NET Build and Versioning Improvements

2022-06-17 Thread Maxim Muzafarov
Folks, Thans everyone for the review. I've merged the issue. https://issues.apache.org/jira/browse/IGNITE-17141 On Tue, 14 Jun 2022 at 11:07, Pavel Tupitsyn wrote: > > Maxim, > > Agree with the suffix digit logic change. > Please see my comments on GitHub and in JIRA. > > On Mon, Jun 13, 2022 a

Re: .NET Build and Versioning Improvements

2022-06-14 Thread Pavel Tupitsyn
Maxim, Agree with the suffix digit logic change. Please see my comments on GitHub and in JIRA. On Mon, Jun 13, 2022 at 4:16 PM Maxim Muzafarov wrote: > Pavel, > > > I've found some minor issue with the last digits in thin client > version - 2.14.0.62943. The last digits is the number of hours p

Re: .NET Build and Versioning Improvements

2022-06-13 Thread Maxim Muzafarov
Pavel, I've found some minor issue with the last digits in thin client version - 2.14.0.62943. The last digits is the number of hours passed since 01-01-2015 [1]. Due to the last number can't be greater than 65534 (UInt16.MaxValue - 1 = 65534) there are only about 100 days left to overceed the li

Re: .NET Build and Versioning Improvements

2022-06-08 Thread Maxim Muzafarov
Folks, Make sense. Another tricky question is - can we have the following version committed in the source files 2.14.0.0, but when the 'release' profile get activated (or probably the build happened) revision number will changed to 2.14.0.62943? This will be the final release version ready for dep

Re: .NET Build and Versioning Improvements

2022-06-08 Thread Pavel Tupitsyn
> As for the last number in .NET version, AFAIK it is used as the unique > build id and is required for nightly builds as nuget doesn't have > functionality a-la maven's 'snapshots' NuGet supports string suffixes like 2.15.0-nightly1. However, AssemblyVersionAttribute does not. In some cases it is

Re: .NET Build and Versioning Improvements

2022-06-08 Thread Ivan Daschinsky
As for the last number in .NET version, AFAIK it is used as the unique build id and is required for nightly builds as nuget doesn't have functionality a-la maven's 'snapshots' ср, 8 июн. 2022 г. в 16:07, Ivan Daschinsky : > Since nuget packages have been built on the same linux agent as the main

Re: .NET Build and Versioning Improvements

2022-06-08 Thread Ivan Daschinsky
Since nuget packages have been built on the same linux agent as the main release, it sounds logical to me that this step can be done within the maven lifecycle. I am for it, +1 ср, 8 июн. 2022 г. в 15:13, Maxim Muzafarov : > Hello Igniters, > > > I'd like to simplify the release build for the Apa