Re: [VOTE][EXTENSION] Release Apache Ignite Spring Boot extensions 1.0.0 RC1

2020-04-30 Thread Nikolay Izhikov
OK. I will rename them and restart the vote. > 30 апр. 2020 г., в 19:11, Denis Magda написал(а): > > Nikolay, > > I didn't do a good job explaining why the artifact for the thin client > should be renamed. Sorry about that. > > It's not my taste or personal preference. It just happened that m

Re: [VOTE][EXTENSION] Release Apache Ignite Spring Boot extensions 1.0.0 RC1

2020-04-30 Thread Denis Magda
Nikolay, I didn't do a good job explaining why the artifact for the thin client should be renamed. Sorry about that. It's not my taste or personal preference. It just happened that make folks from the users and dev communities refer to thick clients as "clients" not using "thick" in conversations

Re: [VOTE][EXTENSION] Release Apache Ignite Spring Boot extensions 1.0.0 RC1

2020-04-30 Thread Maxim Muzafarov
Nikolay, I tend to agree with Denis that it's better to have module naming for which type of Ignite client an appropriate module is built (thin or thick). But it's minor issue. Should modules be agnostic to ignite-core versions? Thus will help us not to rebuild modules each time Apache Ignite rel

Re: [VOTE][EXTENSION] Release Apache Ignite Spring Boot extensions 1.0.0 RC1

2020-04-30 Thread Ilya Kasnacheev
Hello! I had two points: Let's remove "client node" in documentation of autoconfigure module can also create server nodes. Let's rename "-client" to "-thin-client". This is not something we can change later. I hope to test your deliverable later. Regards, -- Ilya Kasnacheev чт, 30 апр. 2020 г

Re: [VOTE][EXTENSION] Release Apache Ignite Spring Boot extensions 1.0.0 RC1

2020-04-30 Thread Nikolay Izhikov
Hello, Ilya. Sorry, I don’t understand your question. Documentation - https://apacheignite-mix.readme.io/docs/spring-boot Extension modules automatically creates the instance of Ignite or IgniteClient inside spring-boot application. Ignite node would be in a client or server mode based on the p

Re: [VOTE][EXTENSION] Release Apache Ignite Spring Boot extensions 1.0.0 RC1

2020-04-30 Thread Ilya Kasnacheev
Hello! - ignite-spring-boot-autoconfigure - to use Ignite Client Node inside your application. - ignite-spring-boot-client-autoconfigure - to use Ignite Thin Client

Re: [VOTE][EXTENSION] Release Apache Ignite Spring Boot extensions 1.0.0 RC1

2020-04-30 Thread Nikolay Izhikov
Hello, Denis. Pages moved to - https://apacheignite-mix.readme.io/docs/spring-boot > As for the artifact 'ignite-spring-boot-client-autoconfigure' name, could we > be more specific and change the name to > 'ignite-spring-boot-thin-client-autoconfigure'? I like the current naming :) Let’s relea

Re: [VOTE][EXTENSION] Release Apache Ignite Spring Boot extensions 1.0.0 RC1

2020-04-29 Thread Denis Magda
Hi Nikolay, DOCUMENTATION > https://apacheignite.readme.io/docs/spring-boot-autoconfigure > https://apacheignite.readme.io/docs/ignite-spring-boot-client-autoconfigure I unpublished the pages to ensure they are not visible until we release the extension. In the meantime, we should do the follow

Re: [VOTE][EXTENSION] Release Apache Ignite Spring Boot extensions 1.0.0 RC1

2020-04-29 Thread Nikolay Izhikov
Hello, Igniters and PMC. Please, cast your vote. > 29 апр. 2020 г., в 02:51, Saikat Maitra написал(а): > > +1 > > Yes, we can update the DEVNOTES.txt in the next release. > > Regards, > Saikat > > > On Tue, Apr 28, 2020 at 4:55 AM Maksim Stepachev > wrote: > >> +1 >> >> вт, 28 апр. 2020

Re: [VOTE][EXTENSION] Release Apache Ignite Spring Boot extensions 1.0.0 RC1

2020-04-28 Thread Saikat Maitra
+1 Yes, we can update the DEVNOTES.txt in the next release. Regards, Saikat On Tue, Apr 28, 2020 at 4:55 AM Maksim Stepachev wrote: > +1 > > вт, 28 апр. 2020 г. в 11:27, Nikolay Izhikov : > > > *** Formal vote description fixed *** > > > > Dear Community, > > > > I have uploaded a release can

Re: [VOTE][EXTENSION] Release Apache Ignite Spring Boot extensions 1.0.0 RC1

2020-04-28 Thread Maksim Stepachev
+1 вт, 28 апр. 2020 г. в 11:27, Nikolay Izhikov : > *** Formal vote description fixed *** > > Dear Community, > > I have uploaded a release candidate of the two extension modules > `ignite-spring-boot-autoconfigure` and > `ignite-spring-boot-client-autoconfigure`. > > The following staging can be

Re: [VOTE][EXTENSION] Release Apache Ignite Spring Boot extensions 1.0.0 RC1

2020-04-28 Thread Nikolay Izhikov
*** Formal vote description fixed *** Dear Community, I have uploaded a release candidate of the two extension modules `ignite-spring-boot-autoconfigure` and `ignite-spring-boot-client-autoconfigure`. The following staging can be used for testing: https://repository.apache.org/content/reposito

Re: [VOTE][EXTENSION] Release Apache Ignite Spring Boot extensions 1.0.0 RC1

2020-04-28 Thread Nikolay Izhikov
Hello, Saikat, Denis. Thanks for feedback. > 2. Also this voting is for Apache Ignite Spring Boot extensions 1.0.0 RC1 > instead of Apache Ignite Ignite 2.8.0-rc1. Is this correct? Good catch, thank you. > As you might remember, we agreed to update the release process [1] I missed that we agr

Re: [VOTE][EXTENSION] Release Apache Ignite Spring Boot extensions 1.0.0 RC1

2020-04-27 Thread Saikat Maitra
Hi Nikolay, 1. Can we update the DEVNOTES.txt to contain build command as below "mvn clean install" instead of "mvn clean install -Pall-java,all-scala,licenses -DskipTests" I have verified that the build passes with tests and also we do not have tasks such as all-java, all-scala or licenses.

Re: [VOTE][EXTENSION] Release Apache Ignite Spring Boot extensions 1.0.0 RC1

2020-04-27 Thread Denis Magda
Hi Nikolay, Sorry for being picky about the documentation but I would encourage us as the community to prepare this release artifact before sending a release for a vote. As you might remember, we agreed to update the release process [1] to ensure this practice is followed. Just in case that's a re

Re: [VOTE][EXTENSION] Release Apache Ignite Spring Boot extensions 1.0.0 RC1

2020-04-27 Thread Sergei Ryzhov
+1 пн, 27 апр. 2020 г. в 23:26, Nikolay Izhikov : > +1 (binding) > > I’ve checked uploaded artifacts with the test application [1] > > [1] https://github.com/nizhikov/ignite-spring-boot-autoconfigure-example > > > 27 апр. 2020 г., в 23:24, Nikolay Izhikov > написал(а): > > > > Dear Community, >

Re: [VOTE][EXTENSION] Release Apache Ignite Spring Boot extensions 1.0.0 RC1

2020-04-27 Thread Nikolay Izhikov
+1 (binding) I’ve checked uploaded artifacts with the test application [1] [1] https://github.com/nizhikov/ignite-spring-boot-autoconfigure-example > 27 апр. 2020 г., в 23:24, Nikolay Izhikov написал(а): > > Dear Community, > > I have uploaded a release candidate of the two extension modules