Re: [Proposal] Ignite 3 Code Style: Enforcement and Evolution

2025-03-17 Thread Stanislav Lukyanov
I assume we're good to go here - I'll start creating and implementing ticket and update the wiki page. Thanks, Stan On Mar 13, 2025 at 13:33 -0400, Stanislav Lukyanov , wrote: > Mirza, > > Yes, your link is correct. It looks like there was a typo in mine. > > Ivan, > > Re enforcing code style on

Re: [Proposal] Ignite 3 Code Style: Enforcement and Evolution

2025-03-13 Thread Stanislav Lukyanov
Mirza, Yes, your link is correct. It looks like there was a typo in mine. Ivan, Re enforcing code style on review. Yes and no - you should, of course, speak up if you see code style issues. But you should not expect to see them if the TC is green. If there is a green TC but still code style is

Re: [Proposal] Ignite 3 Code Style: Enforcement and Evolution

2025-03-13 Thread Ivan Bessonov
Hi everyone! I have a few points in response. > It is assumed that if the PR passes the standard test suite, it adheres to the code style; if not, it is a test suite problem. Such an approach makes sense in theory, but until we have enough rules, enforcing them through review is a viable option.

Re: [Proposal] Ignite 3 Code Style: Enforcement and Evolution

2025-03-12 Thread Mirza Aliev
Hello Stan! Thank you for your idea! Link in the description leads to a non-existing page, is it intentional? What about this already existing [1] page then? [1] https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide чт, 13 мар. 2025 г. в 08:45, Stanislav Lukyanov : > Hello I