Hello!
I think that we should issue a developer warning with LT.warn.
I don't think we should raise an exception. Our code may not have enough
information. For example, it is possible that the data is collocated via
constraint observed by user, such as, ina table of key (id, affKey) there
is join
Maxim it`s cool that it`s moved :)
+1 for exception, but take into account such use case :
T1 (country, city) affinity_key=country and T2 (country,city)
affinity_key=country join with «city» usage — will be correct here (i hope,
need to recheck of course) thus seems you must give some flag\h
I think it should be the first option - just throw a clear exception if a
query with a non-colocated join is executed without the flag set.
Explicitly turning this mode on seems wrong, because in most cases this is
not what a user intends to do.
We also should make sure to run performance tests. A
