Maxim,
> 1. The Apache Ignite may start multiple instances...
Ignite codebase contains something more than Ignite instances code:
control utility, tests. And it does not sound good to me to use some
project-specific naming rule if it is not really critical. I wish
Ignite coding guidelines are as c
Pavel, Ivan,
Let me clarify some details you missed which may lead you to the light side.
1. The Apache Ignite may start multiple instances on the same VM, so
keeping a class field `static` for mutable objects have no sense in
most of the cases. In case of keeping, the immutable structure will b
Hi, Maxim
> But what exactly is `constant` means?! I'd suggest applying this rule
> to all class fields with `static final` modifiers without any clauses.
> (check Java Naming convention [2] paragraph 3.3).
I read this convention [1] and found clarifying exclusion (3.3.2):
All static final object
>> +1 to force upper case for `static final` variables.
+1 too
On Mon, Apr 27, 2020 at 12:08 PM Nikolay Izhikov
wrote:
> +1 to force upper case for `static final` variables.
>
> > 25 апр. 2020 г., в 07:39, Ivan Pavlukhin
> написал(а):
> >
> > Maxim,
> >
> > Thank you for efforts in a code quali
+1 to force upper case for `static final` variables.
> 25 апр. 2020 г., в 07:39, Ivan Pavlukhin написал(а):
>
> Maxim,
>
> Thank you for efforts in a code quality improvement!
>
> Unfortunately I do not agree with the proposal. Usually I like to
> refer a following guide [1]. While a question
Maxim,
Thank you for efforts in a code quality improvement!
Unfortunately I do not agree with the proposal. Usually I like to
refer a following guide [1]. While a question "what is a constant" is
not trivial but I suppose that every static final field capitalization
can cause some problems. For e
> All static final object reference types that are never followed by "."
(dot)
With this way of thinking we can say that everything is a constant if we
don't change it - no need for static final.
"Constant" is usually something that you can't change, even you want -
compiler won't let you.
In Java
Maxim,
> But what exactly is `constant` means?! I'd suggest applying this rule
> to all class fields with `static final` modifiers without any clauses.
> (check Java Naming convention [2] paragraph 3.3).
I disagree with this and want to clarify what exactly the Java naming
convention says:
>> Th
Maxim, It's a good idea!
Please don't forget to update out code style guidelines too.
Thank you for keeping the code cleaner!
пт, 24 апр. 2020 г. в 19:49, Maxim Muzafarov :
> Igniters,
>
>
> It is not directly mentioned through the Apache Ignite Coding
> Guidelines [1] about naming the `static
