RE: Issue - IGNITE-15348

2021-11-25 Thread Andrei Demidov
Thanks!

Re: Issue - IGNITE-15348

2021-11-25 Thread Alex Plehanov
Nikolay, Andrei, I've already merged the patch. чт, 25 нояб. 2021 г. в 14:36, Nikolay Izhikov : > Hello, Andrei. > > I will review your changes shortly. > > > 25 нояб. 2021 г., в 14:31, Andrei Demidov > написал(а): > > > > Hi! > > > > Could somebody please explain me. > > Should I do something

Re: Issue - IGNITE-15348

2021-11-25 Thread Andrei Demidov
Ok, thanks!

Re: Issue - IGNITE-15348

2021-11-25 Thread Nikolay Izhikov
Hello, Andrei. I will review your changes shortly. > 25 нояб. 2021 г., в 14:31, Andrei Demidov > написал(а): > > Hi! > > Could somebody please explain me. > Should I do something for my changes to be merged? > In contributing guide it's said that changes will be merged by any committer > aft

Re: Issue - IGNITE-15348

2021-11-25 Thread Andrei Demidov
Hi! Could somebody please explain me. Should I do something for my changes to be merged? In contributing guide it's said that changes will be merged by any committer after review. Thanks!

Re: Issue - IGNITE-15348

2021-11-18 Thread Andrei Demidov
Ok, thanks! Will mention you in Jira as reviewer.

Re: Issue - IGNITE-15348

2021-11-18 Thread Maksim Timonin
Hi, there are flaky tests. TC wrote a green visa to the ticket. So, everything is fine now. I'll check your PR tomorrow. Thanks! On Thu, Nov 18, 2021 at 2:15 PM Andrei Demidov wrote: > Hi! > > Seems like everything in my PR built successfully. > But I still get errors while checking TeamCity,

Re: Issue - IGNITE-15348

2021-11-18 Thread Andrei Demidov
Hi! Seems like everything in my PR built successfully. But I still get errors while checking TeamCity, but I didn't change the functionality, just deleted whitespaces. Could somebody, please, explain. Thanks!

Re: Issue - IGNITE-15348

2021-11-17 Thread Andrei Demidov
I see now. My bad, great thanks.

Re: Issue - IGNITE-15348

2021-11-16 Thread Maksim Timonin
Hi, you don't fix all issues. You can check it there: https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_Build/6272643?logFilter=debug [INFO] Starting audit... 18:51:20

Re: Issue - IGNITE-15348

2021-11-16 Thread Andrei Demidov
Hello! I've changed checkstyle.xml and deleted all whitespaces after ')', when needed, then committed to fork and created pull request. But for some reason lots of tests fail, but I haven't changed any functionality. I am complete newbie, could anybody please explain me, what should I do now? Th

Re: Issue - IGNITE-15348

2021-11-15 Thread Nikolay Izhikov
Hello, Andrei. Welcome to the Apache Ignite community. I’ve added you to the Contributors list. You can assign JIRA to yourself. > 15 нояб. 2021 г., в 15:26, Andrei Demidov > написал(а): > > Hello Ignite Community! > > My name is Andrei. I want to contribute to Apache Ignite and want to star