Re: Problem with dropping the index

2021-07-15 Thread andrei
Hi, Do you have JIRA tickets for this change? I did not see this in the conversation. Andrey 7/8/2021 4:51 PM, Alexei Scherbakov пишет: I assume DurableBackgroundTask will no longer use references to root ids. The proposed solution looks good to me. чт, 8 июл. 2021 г. в 10:28, Ivan Besso

Re: Problem with dropping the index

2021-07-08 Thread Alexei Scherbakov
I assume DurableBackgroundTask will no longer use references to root ids. The proposed solution looks good to me. чт, 8 июл. 2021 г. в 10:28, Ivan Bessonov : > Hi guys, > > I see that the original message and its clarification is hard to consume. > The problem is that indexes are identified by

Re: Problem with dropping the index

2021-07-08 Thread Ivan Bessonov
Hi guys, I see that the original message and its clarification is hard to consume. The problem is that indexes are identified by their names. So, the situation that Kirill described is a valid one: - you have index X for columns (a, b); - you drop it; - you create index X for columns (a, c). This

Re: Problem with dropping the index

2021-07-07 Thread ткаленко кирилл
I'll try to explain: We create indexes through InlineIndexFactory#createIndex, where at the beginning we create the root page using QueryIndexDefinition#treeName, so if we create the same index 2 times, then we will refer to the same root. In order to make the deletion of the index independent,

Re: Problem with dropping the index

2021-07-07 Thread Alexei Scherbakov
вт, 6 июл. 2021 г. в 15:57, ткаленко кирилл : > >> Can you clarify what it means to rename root index trees ? > Replacing > org.apache.ignite.internal.processors.cache.persistence.IndexStorageImpl.IndexItem, > changing IndexItem#idxName, but keeping fIndexItem#pageId. > Changing to what ? Some te

Re: Problem with dropping the index

2021-07-06 Thread ткаленко кирилл
>> Can you clarify what it means to rename root index trees ? Replacing org.apache.ignite.internal.processors.cache.persistence.IndexStorageImpl.IndexItem, changing IndexItem#idxName, but keeping fIndexItem#pageId. Suggested solution is not suitable for the situation: add index -> drop index ->

Re: Problem with dropping the index

2021-07-06 Thread Alexei Scherbakov
Can you clarify what it means to rename root index trees ? The simple solution which immediately comes to me is 1) write logical record on index creation - on reading it create an index during logical recovery 2) write logical record on index deletion - on reading it delete an index during logica

Problem with dropping the index

2021-07-06 Thread ткаленко кирилл
Hello everyone! Currently, dropping indexes consists of the following steps (based on SchemaAbstractDiscoveryMessage's): Step 1: Removing the index from the SQL engine and starting DurableBackgroundCleanupIndexTreeTask, which removes the index trees in the background; Step 1.1: DurableBack