Re: Ignite 2.7.5 Release scope

2019-04-23 Thread Dmitriy Pavlov
g/jira/browse/IGNITE-11600 >> >>>>>>>>>>> >> >>>>>>>>>>> Sincerely, >> >>>>>>>>>>> Dmitriy Pavlov >> >>>>>>>>>>> >> >>>>>>

Re: Ignite 2.7.5 Release scope

2019-04-19 Thread Dmitriy Pavlov
gt;>>>>>> false-positive cluster shutdowns then I'm for the fix > >>>>>> inclusion to > >>>>>>>>> the > >>>>>>>>>>>> release. > >>>>>>>>>>>> >

Re: Ignite 2.7.5 Release scope

2019-04-19 Thread Petr Ivanov
>> >>>>>>>>>>>> As for Java 12, I would put to the next release that we can >>>>>> make >>>>>>>>> shortly >>>>>>>>>>>> after this one. We don't need to w

Re: Ignite 2.7.5 Release scope

2019-04-19 Thread Stepan Pilschikov
gt; so today or tomorrow I'll announce it. >> >>> > >> > >> > >> >>> > >> > >> > Only one thing was suggested is the fix for failure >> >>> handlers. I >> >>> > >> don't >> >

Re: Ignite 2.7.5 Release scope

2019-04-19 Thread Stepan Pilschikov
> >> 12. It > >>> > >> > >> does > >>> > >> > >> > not work now, but with thanks to Andrey G and Ivan P. we > >>> probably > >>> > >> have > >>> > >> > >> not > >>> > >> &g

Re: Ignite 2.7.5 Release scope

2019-04-15 Thread Dmitriy Pavlov
gt; >> > So these 2 fixes are last candidates to come to scope. WDYT? >>> > >> > >> > >>> > >> > >> > Sincerely, >>> > >> > >> > Dmitriy Pavlov >>> > >> > >> > >>> > >&

Re: Ignite 2.7.5 Release scope

2019-04-12 Thread Dmitriy Pavlov
> usability >> > >> issue >> > >> > >> and >> > >> > >> > > doesn't affect the core components. >> > >> > >> > > >> > >> > >> > > In general, I would suggest us to do a code freeze and pu

Re: Ignite 2.7.5 Release scope

2019-04-09 Thread Dmitriy Pavlov
gt; >> > >> > > to another release. We can't include everything. > > >> > >> > > > > >> > >> > > - > > >> > >> > > Denis > > >> > >> > > > > >> > >> &

Re: Ignite 2.7.5 Release scope

2019-04-08 Thread Nikolay Izhikov
enis > >> > >> > > > >> > >> > > > >> > >> > > On Thu, Mar 28, 2019 at 3:01 AM Ilya Kasnacheev < > >> > >> > ilya.kasnach...@gmail.com > >> > >> > > > > >> > >> > > wrote: > >> > >> > > > >> > >> > > &

Re: Ignite 2.7.5 Release scope

2019-04-02 Thread Dmitriy Pavlov
> >> > > > Hello! >> > >> > > > >> > >> > > > How about adding >> > https://issues.apache.org/jira/browse/IGNITE-11366 >> > >> > > which >> > >> > > > fixes Python's release directory? >> > >>

Re: Ignite 2.7.5 Release scope

2019-03-29 Thread Dmitriy Pavlov
gt;> > > > чт, 28 мар. 2019 г. в 04:19, Roman Shtykh > > > >> >: > > >> > > > > > >> > > > > Dmitriy, the probability of having nodes down with these bugs > > >> under > > >> > > heavy > > &g

Re: Ignite 2.7.5 Release scope

2019-03-29 Thread Denis Magda
t;> > > heavy > >> > > > > load conditions is pretty high. Good candidate for > cherry-picking. > >> > > > > > >> > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9803[2] > >> > > > > https://issues.apache.org/j

Re: Ignite 2.7.5 Release scope

2019-03-29 Thread Dmitriy Pavlov
icking. >> > > > > >> > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9803[2] >> > > > > https://issues.apache.org/jira/browse/IGNITE-11127 >> > > > > -- Roman >> > > > > >> > > > > >> > > > > On Wed

Re: Ignite 2.7.5 Release scope

2019-03-29 Thread Dmitriy Pavlov
> dpav...@apache.org> wrote: > > > > > > > > > > Hi, > > > > > > > > > > I've cherry-picked this commit. It seems it is critical because it > > also > > > > > fixes storage corruption. > > > > > >

Re: Ignite 2.7.5 Release scope

2019-03-28 Thread Denis Magda
t; Hi, > > > > > > > > I've cherry-picked this commit. It seems it is critical because it > also > > > > fixes storage corruption. > > > > > > > > Sincerely, > > > > Dmitriy Pavlov > > > > > > > > вт, 26

Re: Ignite 2.7.5 Release scope

2019-03-28 Thread Dmitriy Pavlov
s storage corruption. > > > > > > Sincerely, > > > Dmitriy Pavlov > > > > > > вт, 26 мар. 2019 г. в 14:14, Zhenya Stanilovsky > > > > >: > > > > > > > I suppose this ticket [1] : is very useful too. > > > > > >

Re: Ignite 2.7.5 Release scope

2019-03-28 Thread Denis Magda
> > [1] https://issues.apache.org/jira/browse/IGNITE-10873 [ > > > CorruptedTreeException during simultaneous cache put operations ] > > > > > > > > > > > > > > >--- Forwarded message --- > > > >From: "Alexey Goncharu

Re: Ignite 2.7.5 Release scope

2019-03-28 Thread Ilya Kasnacheev
age --- > > >From: "Alexey Goncharuk" < alexey.goncha...@gmail.com > > > >To: dev < dev@ignite.apache.org > > > >Cc: > > >Subject: Re: Ignite 2.7.5 Release scope > > >Date: Tue, 26 Mar 2019 13:42:59 +0300 > > > > &g

Re: Ignite 2.7.5 Release scope

2019-03-27 Thread Roman Shtykh
t; > [1] https://issues.apache.org/jira/browse/IGNITE-10873 [ > CorruptedTreeException during simultaneous cache put operations ] > > > > > > >--- Forwarded message --- > >From: "Alexey Goncharuk" < alexey.goncha...@gmail.com > > >To: dev

Re: Ignite 2.7.5 Release scope

2019-03-27 Thread Andrey Gura
Ivan, I've already point to problem place. So we just have to fix it. On Wed, Mar 27, 2019 at 10:16 PM Павлухин Иван wrote: > > Andrey, > > There is no method JavaNioAccess.newDirectByteBuffer which is used in > our code caused the problem. > > > We are going in the similar way: > > Our way is s

Re: Ignite 2.7.5 Release scope

2019-03-27 Thread Павлухин Иван
Andrey, There is no method JavaNioAccess.newDirectByteBuffer which is used in our code caused the problem. > We are going in the similar way: Our way is similar, but it does not work in java 12. I think it is for separate thread. Let's stop live coding =) ср, 27 мар. 2019 г. в 22:15, Andrey Gu

Re: Ignite 2.7.5 Release scope

2019-03-27 Thread Andrey Gura
>>> I believe we should just add export of jdk.internal.access package to our scripts and TC configurations. Unfortunately it isn't enough! We have to modify GridUnsafe#javaNioAccessObject method. On Wed, Mar 27, 2019 at 10:08 PM Andrey Gura wrote: > > It seems that SharedSecrets is moved to jdk

Re: Ignite 2.7.5 Release scope

2019-03-27 Thread Andrey Gura
>> Just a thought regarding a particular error, we can borrow some ideas from netty. We are going in the similar way: https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/util/GridUnsafe.java#L1467 On Wed, Mar 27, 2019 at 9:38 PM Павлухин Иван wrote:

Re: Ignite 2.7.5 Release scope

2019-03-27 Thread Andrey Gura
It seems that SharedSecrets is moved to jdk.internal.access package. See PR for OpenJ9 [1]. I believe we should just add export of jdk.internal.access package to our scripts and TC configurations. [1] https://github.com/eclipse/openj9/pull/3824 On Wed, Mar 27, 2019 at 8:33 PM Dmitriy Pavlov wro

Re: Ignite 2.7.5 Release scope

2019-03-27 Thread Павлухин Иван
Dmitry, It seems that a lunch becomes more and more expensive =( Just a thought regarding a particular error, we can borrow some ideas from netty [1]. [1] https://github.com/netty/netty/blob/b2eaab092b68f3c61f1e14f39e38c964e5095dd7/common/src/main/java/io/netty/util/internal/PlatformDependent0.

Re: Ignite 2.7.5 Release scope

2019-03-27 Thread Dmitriy Pavlov
I've played with 2.7.5-RC-1 and Java 12, and unfortunately, Ignite can't start without changes: Exception in thread "main" java.lang.ExceptionInInitializerError at org.apache.ignite.internal.util.IgniteUtils.(IgniteUtils.java:795) at org.apache.ignite.internal.IgnitionEx.(IgnitionEx.java:209) at o

Re: Ignite 2.7.5 Release scope

2019-03-27 Thread Ilya Kasnacheev
Hello! So after rebasing I was actually able to get it to pass: https://ci.ignite.apache.org/viewLog.html?buildId=3431647&buildTypeId=IgniteTests24Java8_SpiWindows - Java 11, passed https://ci.ignite.apache.org/viewLog.html?buildId=3431619&buildTypeId=IgniteTests24Java8_SpiWindows - Java 11 withou

Re: Ignite 2.7.5 Release scope

2019-03-26 Thread Dmitriy Pavlov
owse/IGNITE-10873 [ > CorruptedTreeException during simultaneous cache put operations ] > > > > > > >--- Forwarded message --- > >From: "Alexey Goncharuk" < alexey.goncha...@gmail.com > > >To: dev < dev@ignite.apache.org > > >Cc: &g

Re: Ignite 2.7.5 Release scope

2019-03-26 Thread Ilya Kasnacheev
Hello. Yes, locally this test seems to pass. However, no luck on TC. Maybe my commit is positioned on top of especially unlucky HEAD. Anyway, my point was thatTcpDiscoverySslTrustedUntrustedTest (or any other intra-node SSL test) is a sufficient test for IGNITE-11299. It will very reliably hang

Ignite 2.7.5 Release scope

2019-03-26 Thread Zhenya Stanilovsky
mail.com > >To: dev < dev@ignite.apache.org > >Cc: >Subject: Re: Ignite 2.7.5 Release scope >Date: Tue, 26 Mar 2019 13:42:59 +0300 > >Hello Ilya, > >I do not see any issues with the mentioned test. I see the following output >in the logs: > >[21:41:44] : [Step 4

Re: Ignite 2.7.5 Release scope

2019-03-26 Thread Alexey Goncharuk
Hello Ilya, I do not see any issues with the mentioned test. I see the following output in the logs: [21:41:44] : [Step 4/5] [2019-03-22 21:41:44,970][INFO ][main][root] >>> Stopping test: TcpDiscoveryCoordinatorFailureTest#testCoordinatorFailedNoAddFinishedMessageStartOneNode in 37768 ms <<< [21

Re: Ignite 2.7.5 Release scope

2019-03-26 Thread Ilya Kasnacheev
Hello! If you ask me I vote +0,5 either, I am not entirely confident but I answer a huge volume of questions on userlist which boil down to prematory SYSTEM_WORKER_TERMINATION. Regards, -- Ilya Kasnacheev вт, 26 мар. 2019 г. в 11:24, Dmitriy Pavlov : > +0.5 from me from release point of view.

Re: Ignite 2.7.5 Release scope

2019-03-26 Thread Dmitriy Pavlov
+0.5 from me from release point of view. If community agrees with solution, I can cherry pick fix later. вт, 26 мар. 2019 г., 8:59 Roman Shtykh : > Andrey, hmm, I don't think putting back the behavior (if it's safe) we > used to have with all those exceptions being logged etc. is hiding. I would

Re: Ignite 2.7.5 Release scope

2019-03-25 Thread Roman Shtykh
Andrey, hmm, I don't think putting back the behavior (if it's safe) we used to have with all those exceptions being logged etc. is hiding. I would never propose something like that. Btw, I have fixed the issue. If it looks good let's merge. -- Roman On Tuesday, March 26, 2019, 2:46:08 p.m

Re: Ignite 2.7.5 Release scope

2019-03-25 Thread Andrey Kuznetsov
Roman, I think the worst thing we can do is to hide the bug you discovered. The sane options are either fix it urgently or classify it as non-critical and postpone. вт, 26 мар. 2019 г. в 05:13, Roman Shtykh : > Guys, what do you think about disabling SYSTEM_WORKER_TERMINATION > (introduced with I

Re: Ignite 2.7.5 Release scope

2019-03-25 Thread Roman Shtykh
Guys, what do you think about disabling SYSTEM_WORKER_TERMINATION (introduced with IEP-14) before "cluster shutdown" bugs are fixed, as suggested by Nikolay I. in "GridDhtInvalidPartitionException takes the cluster down" thread? -- Roman On Tuesday, March 26, 2019, 3:41:29 a.m. GMT+9, Dmi

Re: Ignite 2.7.5 Release scope

2019-03-25 Thread Dmitriy Pavlov
Hi Ignite Developers, So because nobody raised any feature I would like to call for scope freeze for 2.7.5. The scope is limited with corruption fix, Java 11 issues addressed. https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.7.5 Also, launch scripts will be tested for Java 12.

Re: Ignite 2.7.5 Release scope

2019-03-25 Thread Ilya Kasnacheev
Hello! It seems that I can no longer test this case, on account of TcpDiscoveryCoordinatorFailureTest#testClusterFailedNewCoordinatorInitialized hanging every time under Java 11 on Windows. Alexey, Ivan, can you please take a look? https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTes

Re: Ignite 2.7.5 Release scope

2019-03-22 Thread Dmitriy Pavlov
Hi Igniters, Let me share a couple more links related to release https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.7.5 Tests (now tests use Java 8): https://mtcga.gridgain.com/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAllNightly&baseBranchForTc=ignite-2.7&branchForTc=

Re: Ignite 2.7.5 Release scope

2019-03-22 Thread Ilya Kasnacheev
Hello! Basically there is a test that explicitly highlights this problem, that is running SSL tests on Windows + Java 11. They will hang on Master but pass with this patch. I have started that on TC, results will probably be available later today: https://ci.ignite.apache.org/viewType.html?buildT

Re: Ignite 2.7.5 Release scope

2019-03-22 Thread Maxim Muzafarov
Dmitry, Ilya, Yes, I've looked through those changes [1] as they can affect my local PR. Basically, changes look good to me. I'm not an expert with CommunicationSpi component, so can miss some details and I haven't tested these changes under Java 11. One more thing I'd like to say, I would add a

Re: Ignite 2.7.5 Release scope

2019-03-21 Thread Dmitriy Pavlov
Hi Igniters, fix https://issues.apache.org/jira/browse/IGNITE-11299 Avoid busy wait on processWrite during SSL handshake. seems to be blocker cause it is related to Java 11 I see Maxim M left some comments. Ilya K., Maxim M.were these comments addressed? The ticket is in Patch Available. Reviewe

Re: Ignite 2.7.5 Release scope

2019-03-21 Thread Petr Ivanov
Huge +1 Will try to add new JDK in nearest time to our Teamcity. > On 21 Mar 2019, at 16:27, Dmitriy Pavlov wrote: > > Hi Igniters, > > Meanwhile, Java 12 GA is available. I suggest at least test our new tests > scripts with a couple of Java builds. WDYT? > > Sincerely, > Dmitriy Pavlov > >

Re: Ignite 2.7.5 Release scope

2019-03-21 Thread Dmitriy Pavlov
Hi Igniters, Meanwhile, Java 12 GA is available. I suggest at least test our new tests scripts with a couple of Java builds. WDYT? Sincerely, Dmitriy Pavlov ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov : > Hi Ignite Developers, > > In a separate discussion, I've shared a log with all commits. >

Ignite 2.7.5 Release scope

2019-03-20 Thread Dmitriy Pavlov
Hi Ignite Developers, In a separate discussion, I've shared a log with all commits. As far as I can see, nobody removed commits from this sheet, so the scope of release will be discussed in another way: only explicitly declared commits will be cherry-picked. Sincerely, Dmitriy Pavlov