+1 for warning about potential deadlock and improving javadocs
--Yakov
I like the idea to print out a warning if unsorted map is provided. The
fact that there are tons of other ways to get a deadlock doesn't mean that
we should ignore this case which is actually very common.
-Val
On Tue, Oct 31, 2017 at 12:34 PM, Dmitry Pavlov
wrote:
> Vladimir, thank you. Good po
Vladimir, thank you. Good point for optimistic tx, but still putAll usage
require using sorted collections.
User, of course, may broke this scenario also by using sorted maps with
incorrect custom comparators (one asc, one desc).
Producing warning in code for Igntie for potential deadlock is good
u
Vladimir,
That’s an oversight and lack of explanation on our side. The goal is to avoid
unexpected deadlocks when a user passed a HashMap in cache.putAll. Before
printing out a warning we can filter out OPTIMISTIC/SERIALIZABLE and other
suitable scenarios.
So you’re free to offer another solut
Guys,
Printing a warning in this case is really strange idea. First, how would
explain it in case of OPTIMISTIC/SERIALIZABLE transactions where deadlocks
are impossible? Second, what would you do in case tow sorted maps are
passed one by one in a transaction? User still may have a deadlock. :Last,
Here is a ticket for the improvement:
https://issues.apache.org/jira/browse/IGNITE-6804
—
Denis
> On Oct 31, 2017, at 3:55 AM, Dmitry Pavlov wrote:
>
> I agree with Denis, if we don't have such warning we should continiously warn
> users in wiki pages/blogs/presentations. It is simpler to warn
I agree with Denis, if we don't have such warning we should continiously
warn users in wiki pages/blogs/presentations. It is simpler to warn from
code.
What do you think if we will issue warning only if size > 1. HashMap with 1
item will not cause deadlock. Moreover where can be some custom single
Denis,
We should definitely print out a thorough warning if HashMap is passed into
a bulk method (instead of SortedMap). However, we should make sure that we
only print that warning once and not ever time the API is called.
Can you please file a ticket for 2.4?
D.
On Thu, Oct 26, 2017 at 11:05
+ dev list
Igniters, that’s a relevant point below. Newcomers to Ignite tend to stumble on
deadlocks simply because the keys are passed in an unordered HashMap. Propose
to do the following:
- update bulk operations Java doc.
- print out a warning if a HashMap is used and its exceeds one element.
