Re: IGNITE-6827 - Review needed.

2018-05-29 Thread Dmitry Pavlov
Hi Nick, I can't find any timeouts specified for transaction creation in IGNITE-6967 code (for services cache), so I'm not sure current fix wil help. But anyway soon it can be double-checked with 2.5 release. I hope IGNITE-6967 will be fixed soon in the IEP-17. Vyacheslav Daradur picked up this t

Re: IGNITE-6827 - Review needed.

2018-05-17 Thread npordash
Hi, Would IGNITE-6827 potentially be a workaround for IGNITE-6967? I understand that eventually IGNITE-6967 will not be applicable once the service grid stops using the utility cache and switches to discovery messages, but I've encountered odd deadlocks with PME and I'm growing more suspicious tha

Re: IGNITE-6827 - Review needed.

2018-04-24 Thread Ivan Daschinsky
Hi all, I've implemented corresponded .NET api. Pavel, could you review my PR, please? https://issues.apache.org/jira/browse/IGNITE-8075 2018-04-10 21:06 GMT+03:00 Dmitry Pavlov : > Hi Pavel, > > thank you for bring up test questions. It seems my previous comments were > not taken into account

Re: IGNITE-6827 - Review needed.

2018-04-10 Thread Dmitry Pavlov
Hi Pavel, thank you for bring up test questions. It seems my previous comments were not taken into account. Igniters, let me remind we should get passing TC suites before merge, https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers (hi

Re: IGNITE-6827 - Review needed.

2018-04-09 Thread Pavel Tupitsyn
> Pavel Tupitsyn, what about .NET stuff ? 1) Thank you for filing the ticket, personally I have no plans to work on it in the near future. 2) .NET tests fail, please make sure they are fixed before merging: https://ci.ignite.apache.org/viewLog.html?buildId=1175956 TransactionsParityTest should b

Re: IGNITE-6827 - Review needed.

2018-04-09 Thread Alexei Scherbakov
Guys, I've slightly modified public API javadoc as Denis Magda has suggested in PR review. Please take a look. Pavel Tupitsyn, what about .NET stuff ? I provided all necessary information in ticket [2] Upsource link [1] [1] https://reviews.ignite.apache.org/ignite/branch/PR%203624 [2] https:

Re: IGNITE-6827 - Review needed.

2018-04-09 Thread Alexey Goncharuk
I am not aware of any additional timeouts that we are willing to add in the nearest future. 2018-04-09 16:01 GMT+03:00 Dmitriy Setrakyan : > On Mon, Apr 9, 2018 at 5:42 AM, Alexey Goncharuk < > alexey.goncha...@gmail.com > > wrote: > > > Guys, > > > > After the review in Upsource the configuratio

Re: IGNITE-6827 - Review needed.

2018-04-09 Thread Dmitriy Setrakyan
On Mon, Apr 9, 2018 at 5:42 AM, Alexey Goncharuk wrote: > Guys, > > After the review in Upsource the configuration parameter was renamed > to txTimeoutOnPartMapSync, and it makes sense to me because PME is an > implementation detail and it may change in future, partition map sync is a > more abst

Re: IGNITE-6827 - Review needed.

2018-04-09 Thread Alexey Goncharuk
Guys, After the review in Upsource the configuration parameter was renamed to txTimeoutOnPartMapSync, and it makes sense to me because PME is an implementation detail and it may change in future, partition map sync is a more abstract term. For the same reason I like this parameter being placed on

Re: IGNITE-6827 - Review needed.

2018-04-03 Thread Andrey Gura
Alexey, could you please create code review in Upsource? The PR is huge and it would be great to have an ability to discuss changes in more convenient way. Thanks. On Tue, Apr 3, 2018 at 12:42 AM, Dmitriy Setrakyan wrote: > I looked into the ticket and do not understand this property > name: Ro

Re: IGNITE-6827 - Review needed.

2018-04-02 Thread Dmitriy Setrakyan
I looked into the ticket and do not understand this property name: RollbackOnTopologyChangeTimeout I think what we need to configure is a forceful kill of transactions in case of partition map exchange, right? In that case, the timeout should be configured for PME, not transactions. The property n

Re: IGNITE-6827 - Review needed.

2018-04-02 Thread Andrey Gura
Guys, I've looked at IGNITE-6827 implementation and have comment. I think that rollbackOnTopologyChangeTimeout parameter isn't related with implemented functionality. It's responsibility of PME to rollback transactions that blocks exchange, so rollbackOnTopologyChangeTimeout should be configured f

Re: IGNITE-6827 - Review needed.

2018-04-02 Thread Dmitry Pavlov
Hi Igniters, A number of .NET tests failed, it seems it requied to be updated/fixed first Ignite Platform .NET Core Linux [ tests 2 ] dll: TransactionsParityTest.TestTransactions (master fail rate 0,0%) dll: CachePartitionedTest.TestTransactionScopeMultiCache(True) (master fail rate

Re: IGNITE-6827 - Review needed.

2018-04-02 Thread Alexey Goncharuk
Guys, especially Vladimir Ozerov, Yakov Zhanov, Dmitriy Setrakyan, While the technical side of the change is being reviewed, I would also ask you to pay attention to the public API changes here. --AG 2018-03-21 23:43 GMT+03:00 Pavel Tupitsyn : > Hi Alexei, > > > Pavel Tupitsyn, could you lend

Re: IGNITE-6827 - Review needed.

2018-03-21 Thread Pavel Tupitsyn
Hi Alexei, > Pavel Tupitsyn, could you lend a hand to help completing .NET part (two new public API methods are added as a part of working on [3], java code in branch [2]) Please file a separate ticket for .NET changes. I would like to help, but maybe some time later. No need to delay your chang

Re: IGNITE-6827 - Review needed.

2018-03-21 Thread Dmitry Pavlov
Hi Alexei , Thank you for contribution, unfortunately there is too much tests failed there: .NET is broken Ignite Platform .NET Long Running [ tests 3 ] CachePartitionedNearEnabledTest.TestTransactionScopeMultiCache(True) CachePartitionedTest.TestTransactionScopeMultiCache(True) Cac

IGNITE-6827 - Review needed.

2018-03-20 Thread Alexei Scherbakov
Igniters, I prepared rather important patch [1] related to grid stability and need a review and some help to finish it. Semyon Boikov, could you please take a look on patch code ? [2] Pavel Tupitsyn, could you lend a hand to help completing .NET part (two new public API methods are added as a pa