Re: Re[2]: Discuss idle_verify with moving partitions changes.

2020-03-23 Thread Sergey Antonov
Zhenya, Vlad's message looks incorrectly. How about something like: "Not all partitions were checked. Check of partitions was skipped due to rebalancing is in progress. Please rerun idle_verify after finish rebalancing." пн, 23 мар. 2020 г. в 12:47, Zhenya Stanilovsky : > > Guys thank for quick

Re: Re[2]: Discuss idle_verify with moving partitions changes.

2020-03-23 Thread Ivan Rakov
Partial results are consistent though. I'd add something like "Possible results are not full" instead. On Mon, Mar 23, 2020 at 12:47 PM Zhenya Stanilovsky wrote: > > Guys thank for quick response, Ivan what do you think about Vlad`s > proposal to add additional info like : > "Possible results ar

Re[2]: Discuss idle_verify with moving partitions changes.

2020-03-23 Thread Zhenya Stanilovsky
Guys thank for quick response, Ivan what do you think about Vlad`s proposal to add additional info like : "Possible results are not consistent due to rebalance still in progress" ? Thanks !   >Понедельник, 23 марта 2020, 12:30 +03:00 от Ivan Rakov : >  >Zhenya, > >As for me, the current behavior

Re: Discuss idle_verify with moving partitions changes.

2020-03-23 Thread Ivan Rakov
Zhenya, As for me, the current behavior of idle_verify looks correct. There's no sense in checking MOVING partitions (on which we explicitly inform user), however checking consistency between the rest of owners still makes sense: they still can diverge and we can be aware of the presence of the co

Re: Discuss idle_verify with moving partitions changes.

2020-03-23 Thread Vladislav Pyatkov
Hi Zhenya, I see your point. Need to show some message, because cluster is not idle (rebalance is going). When cluster not idle we cannot validate partitions honestly. After several minutes we can to get absolutely different result, without any client's operation of cache happened. May be enough

Discuss idle_verify with moving partitions changes.

2020-03-23 Thread Zhenya Stanilovsky
Igniters, i found that near idle check commands only shows partitions in MOVING states as info in log and not take into account this fact as erroneous idle cluster state. control.sh --cache idle_verify, control.sh --cache validate_indexes --check-crc   for example command would show something li