Re: [RESULT][VOTE] Add swagger dependency to Ignite 3

2022-05-31 Thread Aleksandr Pakhomov
Andrey, Thanks, done. > On 31 May 2022, at 11:36, Andrey Gura wrote: > > Aleksandr, > > could you please update > https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide#JavaCodeStyleGuide-2Using3rdpartylibraries > >

Re: [RESULT][VOTE] Add swagger dependency to Ignite 3

2022-05-31 Thread Andrey Gura
Aleksandr, could you please update https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide#JavaCodeStyleGuide-2Using3rdpartylibraries On Mon, May 30, 2022 at 12:33 PM Aleksandr Pakhomov wrote: > > Hello Igniters, > > The swagger dependency has been accepted. > > 3 - “+1” votes r

[RESULT][VOTE] Add swagger dependency to Ignite 3

2022-05-30 Thread Aleksandr Pakhomov
Hello Igniters, The swagger dependency has been accepted. 3 - “+1” votes received. 1 - “0.5” vote received. Here are +1 votes received: - Alexander Polovtcev - Andrey Gura - Ivan Pavlukhin Here is -0.5 vote received: - Ilya Kasnacheev (binding) Link to the voting thread - https://lists.apa

Re: [VOTE] Add swagger dependency to Ignite 3

2022-05-26 Thread Ivan Pavlukhin
+1 Aleksandr, thanks for the explanation. Best regards, Ivan Pavlukhin чт, 26 мая 2022 г. в 21:54, Andrey Gura : > > +1 from me. Open API spec could be useful in the future for > implementing external cluster management tools. > > On Thu, May 26, 2022 at 11:41 AM Aleksandr Pakhomov wrote: > > >

Re: [VOTE] Add swagger dependency to Ignite 3

2022-05-26 Thread Andrey Gura
+1 from me. Open API spec could be useful in the future for implementing external cluster management tools. On Thu, May 26, 2022 at 11:41 AM Aleksandr Pakhomov wrote: > > Hi Ivan, > > Dependencies that are needed for annotating > classes are going to be included. From those > annotations Open API

Re: [VOTE] Add swagger dependency to Ignite 3

2022-05-26 Thread Aleksandr Pakhomov
Hi Ivan, Dependencies that are needed for annotating classes are going to be included. From those annotations Open API spec is generated by maven plugin. That’s it. If you are asking about swagger ui or any web stuff then the answer is no. We are not going to include this into production.

Re: [VOTE] Add swagger dependency to Ignite 3

2022-05-25 Thread Ivan Pavlukhin
Hi, Are we going to include swagger into production packages? I always thought (I might be mistaken) that swagger should be used during development. Worries are usual: 1. Potential vulnerabilities. 2. Unintentional use of transitive dependencies. Best regards, Ivan Pavlukhin чт, 26 мая 2022 г. в

Re: [VOTE] Add swagger dependency to Ignite 3

2022-05-25 Thread Mikhail Pochatkin
+1 from me, de facto swagger standard within OpenApi. On Mon, May 23, 2022 at 7:57 PM Aleksandr Pakhomov wrote: > Dear community, > > Discussion about 3rd party dependencies took place > and I think it is time to vote if we agreed to include > swagger dependency to the Ignite 3 or not. > > The e

Re: [VOTE] Add swagger dependency to Ignite 3

2022-05-25 Thread Alexander Polovtcev
+1 from me, I've seen many projects using this approach and I personally find it quite useful On Wed, May 25, 2022 at 5:54 PM Andrey Gura wrote: > Ilya, > > are there any alternatives to Swagger that you could recommend that > don't have the mentioned drawback? > > It seems that OPen API itself

Re: [VOTE] Add swagger dependency to Ignite 3

2022-05-25 Thread Andrey Gura
Ilya, are there any alternatives to Swagger that you could recommend that don't have the mentioned drawback? It seems that OPen API itself doesn't define primitive and wrapped types because such information is language/runtime/etc specific. Maybe this problem will be addressed in the future. On

Re: [VOTE] Add swagger dependency to Ignite 3

2022-05-23 Thread Ilya Kasnacheev
Hello! Back when I looked at it, Swagger was very primitive, such as not supporting primitive types in generated models https://stackoverflow.com/a/45053804/36498 I'm not sure it is the right tool, please clarify why it is needed. -0.5 from me (binding) Regards, -- Ilya Kasnacheev пн, 23 мая

[VOTE] Add swagger dependency to Ignite 3

2022-05-23 Thread Aleksandr Pakhomov
mp;p0=166&msg=[VOTE]+Add+swagger+dependency+to+Ignite+3&font=cursive> > On 23 May 2022, at 19:56, Aleksandr Pakhomov wrote: > > Dear community, > > Discussion about 3rd party dependencies took place > and I think it is time to vote if we agreed to include > s

[VOTE] Add swagger dependency to Ignite 3

2022-05-23 Thread Aleksandr Pakhomov
Dear community, Discussion about 3rd party dependencies took place and I think it is time to vote if we agreed to include swagger dependency to the Ignite 3 or not. The exact list of dependencies could be fined in IEP-87 [1] (swagger-annotations, swagger-core, swagger-codegen-maven-plugin)