Re: [PROPOSAL] Versioned TeamCity settings in Ignite 3

2024-12-20 Thread Pavel Tupitsyn
Regarding security - we should make sure that we don't run scripts changed in PRs from external contributors. If a non-committer changes a TC script in their fork, then we should not start a TC build automatically. I think this can be done in GitHub with workflow approvals. On Fri, Dec 20, 2024 a

Re: [PROPOSAL] Versioned TeamCity settings in Ignite 3

2024-12-20 Thread Pavel Tupitsyn
Mikhail, thank you for taking the initiative. I agree with the Kotlin DSL direction. > slowdown in indexing in the developers' projects IDEA can exclude a folder from indexing [1] - should be an easy workaround. [1] https://www.jetbrains.com/help/idea/indexing.html On Fri, Dec 20, 2024 at 2:22

Re: [PROPOSAL] Versioned TeamCity settings in Ignite 3

2024-12-20 Thread Mikhail Pochatkin
I fully support the proposal regarding the transition to the code base approach. As Peter said, we may have problems with testing the build from branches, but as far as I see in the TC documentation [1] it is stated that this is a fully working feature, if we encounter bugs, then this is not an blo

Re: [PROPOSAL] Versioned TeamCity settings in Ignite 3

2024-12-20 Thread Peter Ivanov
That is a great idea if you understand what you are doing. And awful if not. Currently - settings for all Apache Ignite build projects on TeamCity are ALREADY stored as code in GitHub, as a PMC member you have access to https://github.com/apache-ignite-teamcity/configuration. Though the initial co

Re: [PROPOSAL] Versioned TeamCity settings in Ignite 3

2024-12-19 Thread Mirza Aliev
Great idea! I remember that something similar was planned by Peter Ivanov; it would be nice to hear his thoughts on that. чт, 19 дек. 2024 г. в 14:33, Maksim Myskov : > This is definitely needs to be done. > -- > Maksim Myskov > > > On 19 Dec 2024, at 12:56, Pavel Tupitsyn wrote: > > > > Ignite

Re: [PROPOSAL] Versioned TeamCity settings in Ignite 3

2024-12-19 Thread Maksim Myskov
This is definitely needs to be done. -- Maksim Myskov > On 19 Dec 2024, at 12:56, Pavel Tupitsyn wrote: > > Igniters, > > Currently, our TeamCity projects [1] are UI-defined and are the same for > all branches. > Which has the following issues: > - Can't test project changes in a branch without

Re: [PROPOSAL] Versioned TeamCity settings in Ignite 3

2024-12-19 Thread Aleksandr Polovtsev
Sounds great, are you going to drive this activity? On Thu, Dec 19, 2024 at 11:57 AM Pavel Tupitsyn wrote: > Igniters, > > Currently, our TeamCity projects [1] are UI-defined and are the same for > all branches. > Which has the following issues: > - Can't test project changes in a branch without

[PROPOSAL] Versioned TeamCity settings in Ignite 3

2024-12-19 Thread Pavel Tupitsyn
Igniters, Currently, our TeamCity projects [1] are UI-defined and are the same for all branches. Which has the following issues: - Can't test project changes in a branch without risking broken main - Can't have different settings for different branches (e.g. SDK upgrade in a new version only) - Di