Wonderful, thanks Nikolay!
--
Denis
On Fri, Apr 27, 2018 at 11:50 PM, Nikolay Izhikov
wrote:
> Hell, Denis.
>
> I've done review and merge yersteday.
>
> master commit - https://github.com/apache/ignite/commit/
> fcc4d4a357413eb4856ca5c72d301738568060e2
> 2.5 commit - https://github.com/apache/
Hell, Denis.
I've done review and merge yersteday.
master commit -
https://github.com/apache/ignite/commit/fcc4d4a357413eb4856ca5c72d301738568060e2
2.5 commit -
https://github.com/apache/ignite/commit/2679cc5a18eb00599c9f00b0f46dbcaa6352c0cb
The task is in resolved state.
В Пт, 27/04/2018 в 2
Akmal, Nikolay,
Do you have any progress on this? Let's finish with this ticket within 2.5
scope and merge it there.
--
Denis
On Thu, Apr 19, 2018 at 10:07 PM, Akmal Chaudhri <
akmal.chaud...@gridgain.com> wrote:
> Nikolay,
>
> Ok. I _think_ it should be better now, so we can try again.
>
> 1.
Nikolay,
Ok. I _think_ it should be better now, so we can try again.
1. I removed the 3 pull requests.
2. I renamed the Java code files with a "Java" prefix.
3. I created a test file for the Java code, using the existing test file
for the Scala code.
4. I updated the TestSuite with bullet #3 abov
Hello, Akmal.
1. As a first step. Let's combine all changes you want to merge into a single
pull request.
I suggest that your changes relates only to "examples" module.
2. So, when you will have one pull request, please, run "Examples" test suite
on Team City for your branch.
After that, attac
Nikolay,
The code is the same for the attached version to the ticket, as well as the
pull version. The tests are also the same as those provided for the Scala
DF examples. I have checked and they work correctly with the exception of
the path issue which I previously mentioned on the dev list.
I'm
Hello, Akmal.
I see 3 pull requests attached to the ticket [1], [2], [3].
I see 3 java files attached to the ticket, also.
Which changes you want to be reviewed and merge? Please, clarify.
Delete all unnecessary pull requests link from the ticket.
Add new examples to the tests so we can test it
If any community members have time, please review the code. Three Java
files are attached to the Jira ticket:
https://issues.apache.org/jira/browse/IGNITE-7909
The code should be functionally equivalent to the Scala Data Frames code
that was shipped in 2.4.
Data Frame documentation is here:
htt
Sincerely,
> > Dmitriy Pavlov
> >
> > -- Forwarded message -
> > From: Akmal Chaudhri (JIRA)
> > Date: вс, 11 мар. 2018 г. в 2:24
> > Subject: [jira] [Created] (IGNITE-7909) Java code
bject: [jira] [Created] (IGNITE-7909) Java code examples are needed for
> Spark Data Frames.
> To:
>
>
> Akmal Chaudhri created IGNITE-7909:
> --
>
> Summary: Java code examples are needed for Spark Data Frames.
>
Hi Nikolay,
Сan your examples, that you have done recently, come up as a solution to
this ticket?
Sincerely,
Dmitriy Pavlov
-- Forwarded message -
From: Akmal Chaudhri (JIRA)
Date: вс, 11 мар. 2018 г. в 2:24
Subject: [jira] [Created] (IGNITE-7909) Java code examples are needed
Akmal Chaudhri created IGNITE-7909:
--
Summary: Java code examples are needed for Spark Data Frames.
Key: IGNITE-7909
URL: https://issues.apache.org/jira/browse/IGNITE-7909
Project: Ignite
Iss
12 matches
Mail list logo
