Re: [IEP-35] Metrics management in Ignite

2019-09-25 Thread Nikolay Izhikov
Hello, Andrey. > My proposal target is simplification of metrics adding to the code. > There is no any complexity. That's great. Looking forward for your PR. Please, don't hesitate to request my review for it. В Ср, 25/09/2019 в 13:23 +0300, Andrey Gura пишет: > Nikolay, > > > > 1. There is no

Re: [IEP-35] Metrics management in Ignite

2019-09-25 Thread Andrey Gura
Nikolay, >> 1. There is no unified approach to adding metrics during development. > Yes, we have it. > Just call `MetricRegistry#longMetric` or other method and you got your > counter. I talk about code structure, not API. >> Now the logic is spread throughout the code base and there is now an

Re: [IEP-35] Metrics management in Ignite

2019-09-20 Thread Nikolay Izhikov
Hello, Andrey. Thanks for starting this discussion. > 1. There is no unified approach to adding metrics during development. Yes, we have it. Just call `MetricRegistry#longMetric` or other method and you got your counter. > Now the logic is spread throughout the code base and there is now any >

[IEP-35] Metrics management in Ignite

2019-08-26 Thread Andrey Gura
Hi, Igniters! I'm working on some metrics related aspects and it seems that we have missed some points regarding the metrics management. There are at least two major problems from my point of view. Problem definition. --- 1. There is no unified approach to adding metrics