Re: [DISCUSSION] Remove VS project from C++

2021-10-25 Thread Ivan Daschinsky
FYI: PR is ready [1]. Since we already changed release builds and switched them to CMake, we can proceed with removing. [1] -- https://issues.apache.org/jira/browse/IGNITE-15637 ср, 15 сент. 2021 г. в 13:03, Pavel Tupitsyn : > Ivan, thanks for the answers! I retract my "-1". No objections. > > O

Re: [DISCUSSION] Remove VS project from C++

2021-09-15 Thread Pavel Tupitsyn
Ivan, thanks for the answers! I retract my "-1". No objections. On Wed, Sep 15, 2021 at 12:58 PM Ivan Daschinsky wrote: > >> 1. What percentage of our users rely on existing VS projects? > It is impossible to answer, but I suppose not so much. And, again, these > projects needs some tweaks in or

Re: [DISCUSSION] Remove VS project from C++

2021-09-15 Thread Ivan Daschinsky
>> 1. What percentage of our users rely on existing VS projects? It is impossible to answer, but I suppose not so much. And, again, these projects needs some tweaks in order to work properly in VS 2015+ Moreover, you cannot use VS as is, you should tweak them or download dependencies in specific lo

Re: [DISCUSSION] Remove VS project from C++

2021-09-15 Thread Pavel Tupitsyn
Ivan, Ok, I've got your point. What's your assessment on the following: 1. What percentage of our users rely on existing VS projects? 2. How much time (in minutes) does it take to switch from using existing VS projects to CMake-generated ones? On Wed, Sep 15, 2021 at 12:37 PM Ivan Daschinsky

Re: [DISCUSSION] Remove VS project from C++

2021-09-15 Thread Ivan Daschinsky
>> Currently user Sorry typo, I meant developer. ср, 15 сент. 2021 г. в 12:35, Ivan Daschinsky : > > How? > Currently user must add sources in 2 different places. One of this places > is not specified and not intended to be edit outside VC. > CMake can generate VS projects easily and without any

Re: [DISCUSSION] Remove VS project from C++

2021-09-15 Thread Ivan Daschinsky
> How? Currently user must add sources in 2 different places. One of this places is not specified and not intended to be edit outside VC. CMake can generate VS projects easily and without any problem. I've done this even in 2008 when I was C++/Qt developer. >> 1. Get all files in the directory >>

Re: [DISCUSSION] Remove VS project from C++

2021-09-15 Thread Pavel Tupitsyn
> It makes development much more easier. How? > I can hardly imagine how it can be done 1. Get all files in the directory 2. Filter by TestSuite suffix 3. Check if all of them are present in VS files Am I missing something? We have checks like this for Ignite.NET [1] [1] https://github.com/apac

Re: [DISCUSSION] Remove VS project from C++

2021-09-15 Thread Ivan Daschinsky
>> Please specify more correctly. Sorry, typo, more concretely. ср, 15 сент. 2021 г. в 12:22, Ivan Daschinsky : > >> This may become an obstacle for some of the users and I'm not sure how > it improves anything. > Please specify more correctly. What is an obstacle? Current VS projects > (odbc) ca

Re: [DISCUSSION] Remove VS project from C++

2021-09-15 Thread Ivan Daschinsky
>> This may become an obstacle for some of the users and I'm not sure how it improves anything. Please specify more correctly. What is an obstacle? Current VS projects (odbc) cannot be build on VC 2015+ without modification. CMake is an industry standard now. >> I'm not sure how it improves anythin

Re: [DISCUSSION] Remove VS project from C++

2021-09-15 Thread Petr Ivanov
+1 Let's keep the project clean and on the verge of preferable tech stack. > On 15 Sep 2021, at 12:02, Ivan Pavlukhin wrote: > > +1 for removing VS project > > 2021-09-15 12:01 GMT+03:00, Nikolay Izhikov : >> +1 >> >>> 15 сент. 2021 г., в 11:57, Pavel Tupitsyn >>> написал(а): >>> >>> -1 >>

Re: [DISCUSSION] Remove VS project from C++

2021-09-15 Thread Ivan Pavlukhin
+1 for removing VS project 2021-09-15 12:01 GMT+03:00, Nikolay Izhikov : > +1 > >> 15 сент. 2021 г., в 11:57, Pavel Tupitsyn >> написал(а): >> >> -1 >> >> This may become an obstacle for some of the users and I'm not sure how it >> improves anything. >> >>> 3. Sometimes even maintainers forget to

Re: [DISCUSSION] Remove VS project from C++

2021-09-15 Thread Nikolay Izhikov
+1 > 15 сент. 2021 г., в 11:57, Pavel Tupitsyn написал(а): > > -1 > > This may become an obstacle for some of the users and I'm not sure how it > improves anything. > >> 3. Sometimes even maintainers forget to add test sources to VS projects > [1] > We can add an automatic check for this (in f

Re: [DISCUSSION] Remove VS project from C++

2021-09-15 Thread Pavel Tupitsyn
-1 This may become an obstacle for some of the users and I'm not sure how it improves anything. > 3. Sometimes even maintainers forget to add test sources to VS projects [1] We can add an automatic check for this (in form of a test). On Wed, Sep 15, 2021 at 10:28 AM Zhenya Stanilovsky wrote: >

Re: [DISCUSSION] Remove VS project from C++

2021-09-15 Thread Zhenya Stanilovsky
completely support !   >Igniters! > >Currently we have CMake build system, that works on Windows, Linux and >MacOs flawlessly > >1. CMake is supported natively in VS 2019 >2. CMake can generate VS projects for about 20 years flawlessly. >3. Sometimes even maintainers forget to add test sources to

[DISCUSSION] Remove VS project from C++

2021-09-15 Thread Ivan Daschinsky
Igniters! Currently we have CMake build system, that works on Windows, Linux and MacOs flawlessly 1. CMake is supported natively in VS 2019 2. CMake can generate VS projects for about 20 years flawlessly. 3. Sometimes even maintainers forget to add test sources to VS projects [1] 4. Currently on