Re: [DISCUSSION] Allow use QuerySqlField.precision for varlen types

2021-08-12 Thread Maksim Timonin
Hi, Ivan! I prepared a ticket [1] for this patch, and got the TC bot visa. Could you please have a look at it? [1] https://issues.apache.org/jira/browse/IGNITE-15302 On Thu, Aug 12, 2021 at 8:52 PM Ivan Daschinsky wrote: > Max, i've the same thoughts about varbinary. > > чт, 12 авг. 2021 г. в

Re: [DISCUSSION] Allow use QuerySqlField.precision for varlen types

2021-08-12 Thread Ivan Daschinsky
Max, i've the same thoughts about varbinary. чт, 12 авг. 2021 г. в 18:27, Maksim Timonin : > Hi, Ivan! > > I agree about String. It looks like there is someone who just forgot to > document it. > > But what about binary? H2 supports varbinary type (along with varchar). So > I think we can easily

Re: [DISCUSSION] Allow use QuerySqlField.precision for varlen types

2021-08-12 Thread Maksim Timonin
Hi, Ivan! I agree about String. It looks like there is someone who just forgot to document it. But what about binary? H2 supports varbinary type (along with varchar). So I think we can easily support it. Also it will open the door to an improved inline size calculation for binary types the same

Re: [DISCUSSION] Allow use QuerySqlField.precision for varlen types

2021-08-11 Thread Ivan Daschinsky
Hi, I suppose that we should add javadoc to QuerySqlFileds. It is weird that this feature is not documented. ср, 11 авг. 2021 г. в 00:08, Maksim Timonin : > Hi, Igniters! > > I dived to the precision param of QuerySqlField and SQL data types. The > javadocs of QuerySqlField say that the param is

[DISCUSSION] Allow use QuerySqlField.precision for varlen types

2021-08-10 Thread Maksim Timonin
Hi, Igniters! I dived to the precision param of QuerySqlField and SQL data types. The javadocs of QuerySqlField say that the param is for decimal type only. But actually it works for String fields out of the box. So it looks like an easter egg. I think we should either document it or forbid it. A