Re: [DISCUSS] Public API deprecation rules

2020-02-13 Thread Alexey Goncharuk
I've created a wiki page based on the vote results [1]. Feel free to update the page if it seems incomplete. [1] https://cwiki.apache.org/confluence/display/IGNITE/Development+Guidelines чт, 6 февр. 2020 г. в 20:17, Alexey Goncharuk : > Ivan, thanks, I agree, added this clause: > > The vote we a

Re: [DISCUSS] Public API deprecation rules

2020-02-06 Thread Alexey Goncharuk
Ivan, thanks, I agree, added this clause: The vote we are going to have is reduced to two choices so far: * Never deprecate the old APIs unless the new APIs are stable and released without @IgniteExperimental. The old APIs javadoc may be updated with a reference to new APIs to encourage users to

Re: [DISCUSS] Public API deprecation rules

2020-02-06 Thread Ivan Pavlukhin
A little bit more formalism. The thread subject is about API deprecation in general. But it looks like that discussion boils down to a replacement of old API with a new one. I suppose there should be a possibility to deprecate API for removal if the Community decided to do so. > @IgniteExperimenta

Re: [DISCUSS] Public API deprecation rules

2020-02-06 Thread Alexey Goncharuk
Thanks, updated the justification: The vote we are going to have is reduced to two choices so far: * Never deprecate the old APIs unless the new APIs are stable and released without @IgniteExperimental. The old APIs javadoc may be updated with a reference to new APIs to encourage users to evaluat

Re: [DISCUSS] Public API deprecation rules

2020-02-06 Thread Nikolay Izhikov
Hello, I have two notes > * Allow to deprecate the old APIs even when new APIs are marked with > @IgniteExperimental to explicitly notify users that the new APIs are available I think the main reason is not «notify users that new APIs are available», but «Notify users that old APIs will be rem

Re: [DISCUSS] Public API deprecation rules

2020-02-06 Thread Alexey Goncharuk
Agree, I was implying this option. Corrected: The vote we are going to have is reduced to two choices so far: * Never deprecate the old APIs unless the new APIs are stable and released without @IgniteExperimental. The old APIs javadoc may be updated with a reference to new APIs to encourage users

Re: [DISCUSS] Public API deprecation rules

2020-02-06 Thread Andrey Gura
One comment about first choice. The formulation has one issue from my point of view: Never deprecate the old APIs unless the new APIs are stable *and released* without @IgniteExperimental. Actually we can introduce new stable API and deprecate old API at the same time without releasing of new API

Re: [DISCUSS] Public API deprecation rules

2020-02-05 Thread Denis Magda
The justification and choices look crystal clear to me. - Denis On Wed, Feb 5, 2020 at 1:36 PM Alexey Goncharuk wrote: > Igniters, > > We would like to add some formal requirements to the API deprecation > process. So far the API deprecation was more like intuitive-driven which > recently led

[DISCUSS] Public API deprecation rules

2020-02-05 Thread Alexey Goncharuk
Igniters, We would like to add some formal requirements to the API deprecation process. So far the API deprecation was more like intuitive-driven which recently led to some disagreement and delaying the AI 2.8 release [1][2]. During the discussion [1] we agreed to add an annotation @IgniteExperim