Re: Problem with reading incomplete payload - IGNITE-7153

2018-11-02 Thread Michael Fong
Hi Yakov, Thanks so much for your analysis. Parser expects chunks to be complete and has all the data to read entire > message, but this is not guaranteed and single message can arrive in > several chunks. This is indeed the the assumption to my implementation. I have not come up a another parsi

Re: Problem with reading incomplete payload - IGNITE-7153

2018-10-31 Thread Michael Fong
ct 31, 2018 at 1:06 PM Michael Fong wrote: > Hi Yakov, > > Thanks for your reply. :) > > Please allow me to explain the whole situation and how to reproduce > the problem: > > In the PR of IGNITE-7153, I added a test case under > RedisProtocolConnectSelfTest, sending

Re: Problem with reading incomplete payload - IGNITE-7153

2018-10-30 Thread Michael Fong
Hi Yakov, Thanks for your reply. :) Please allow me to explain the whole situation and how to reproduce the problem: In the PR of IGNITE-7153, I added a test case under RedisProtocolConnectSelfTest, sending some binary data via Jedis client, large enough (> 8192 bytes) to reproduce the original

Re: How to begin to contribute

2018-10-30 Thread Michael Fong
f he is interested in continuing of > developing this issue/or he could apply you PR as well. > > Sincerely, > Dmitriy Pavlov > > пн, 22 окт. 2018 г. в 11:33, Michael Fong : > > > Ah, never mind. I found out that I chose the wrong test suite to begin > with > > o

Re: Problem with reading incomplete payload - IGNITE-7153

2018-10-29 Thread Michael Fong
bump :) On Fri, Oct 26, 2018 at 4:00 PM Michael Fong wrote: > Hi, > > Thanks for your reply. I think current implementation (based on R2.6) does > exactly what you mentioned as of in GridNioServer > <https://github.com/apache/ignite/blob/ignite-2.6/modules/core/src/main/java

Re: Problem with reading incomplete payload - IGNITE-7153

2018-10-26 Thread Michael Fong
tes that are expected have been read > (if sockCh is based on some kind of input stream) > > > Am 26.10.2018 um 04:24 schrieb Michael Fong : > > > > Bump! > > > > Anyone who could help me solve this random issue? Thanks! > > > > Regards, > > >

Re: Problem with reading incomplete payload - IGNITE-7153

2018-10-25 Thread Michael Fong
Bump! Anyone who could help me solve this random issue? Thanks! Regards, Michael On Wed, Oct 24, 2018 at 10:32 PM Michael Fong wrote: > Hi, all, > > > I was trying to fix IGNITE-7153 which relates to parsing incomplete REDIS > packet larger than 8192 bytes. However, I

Problem with reading incomplete payload - IGNITE-7153

2018-10-24 Thread Michael Fong
Hi, all, I was trying to fix IGNITE-7153 which relates to parsing incomplete REDIS packet larger than 8192 bytes. However, I found a random problem which is reproducible on TC as well. That said, GridNioServerRead.processRead() : - int cnt = sockCh.read(readBuf); sometimes does not read the

Re: How to begin to contribute

2018-10-22 Thread Michael Fong
Ah, never mind. I found out that I chose the wrong test suite to begin with on Team City. :-) On Sun, Oct 21, 2018 at 10:20 PM Michael Fong wrote: > Hi, all, > > I happened to have a fix for IGNITE-7153 and created pull request for it. ( > https://github.com/apache/ignite/pull/5044)

How to begin to contribute

2018-10-21 Thread Michael Fong
Hi, all, I happened to have a fix for IGNITE-7153 and created pull request for it. ( https://github.com/apache/ignite/pull/5044) I tried to follow the How to Contribute Workflow but kind of got stuck o