Re: Removal of ignite ml module (or moving it to extensions)

2023-08-16 Thread Aleksei Zinovev
Hi, I have objection for fast merging, (not for moving) as a module maintainer. I never used ignite extension, need a time to be familiar with it and test the pr. Please postpone it till 10 september. I don't understand reasons to do it so fast. I suppose it's ok to wait 15-20 days with PR Than

Re: Removal of ignite ml module (or moving it to extensions)

2023-08-16 Thread Ivan Daschinsky
ML Extensions suite is ready and it works, all tests from the main module and parsers, all examples -- everything works and all green [1]. The green visa has been obtained. So I am going to merge it tomorrow, if there is no objection. [1] --- https://ci.ignite.apache.org/buildConfiguration/Ignit

Re: TX code cleanup (MVCC removal)

2023-08-16 Thread Ivan Daschinsky
The plan looks good to me. Some of the tests are in the ODBC test suite, so i can help if needed. ср, 16 авг. 2023 г. в 16:32, Anton Vinogradov : > Igniters, > > I started the TX code cleanup [1] last month and almost finished with the > obvious garbage. > Now, started the code deduplication, I w

TX code cleanup (MVCC removal)

2023-08-16 Thread Anton Vinogradov
Igniters, I started the TX code cleanup [1] last month and almost finished with the obvious garbage. Now, started the code deduplication, I was faced with code overcomplexity because of unfinished MVCC. The community agreed to remove MVCC, but the initial attempt [2] was not successful because of

Re: Removal of ignite ml module (or moving it to extensions)

2023-08-16 Thread Ivan Daschinsky
>> https://issues.apache.org/jira/browse/IGNITE-20216 Also, I've updated dependencies and fixed BLAS issue (tested with intel mkl blas on ubuntu 22.04) ср, 16 авг. 2023 г. в 12:11, Ivan Daschinsky : > I've filed a ticket and created 2 PRs. After tuning of TC I'm going to > merge both of them, if

Re: Removal of ignite ml module (or moving it to extensions)

2023-08-16 Thread Aleksei Zinovev
Hi, as PMC and maintainer of this module -1 for removal +1 for moving to an extension, if it is compatible with the Ignite and could be compiled separately from other extension modules Some facts: - nobody updates it for latest 3 years—it's true - classic ML algorithms are not changed in t

Re: Removal of ignite ml module (or moving it to extensions)

2023-08-16 Thread Ivan Daschinsky
I've filed a ticket and created 2 PRs. After tuning of TC I'm going to merge both of them, if nobody disagrees with it. https://issues.apache.org/jira/browse/IGNITE-20216 пн, 14 авг. 2023 г. в 22:29, Ivan Daschinsky : > >> * com.github.fommil.netlib:core:1.1.2 - not developed and archived > si