Re: [DISCUSSION] Add additional 3rd party libraries to Ignite 3 Code style and practices

2022-05-25 Thread Mikhail Pochatkin
Hello Igniters. I see that the main argument against Micronaut is that we need Micronaut+Swagger to achieve IEP 87 if we can use only Swagger. I agree this is a valid point and logically. But I think we can take a look into it from another side, from future vision. Main idea to start using microna

Re: [VOTE] Add swagger dependency to Ignite 3

2022-05-25 Thread Ivan Pavlukhin
Hi, Are we going to include swagger into production packages? I always thought (I might be mistaken) that swagger should be used during development. Worries are usual: 1. Potential vulnerabilities. 2. Unintentional use of transitive dependencies. Best regards, Ivan Pavlukhin чт, 26 мая 2022 г. в

Re: [VOTE] Add swagger dependency to Ignite 3

2022-05-25 Thread Mikhail Pochatkin
+1 from me, de facto swagger standard within OpenApi. On Mon, May 23, 2022 at 7:57 PM Aleksandr Pakhomov wrote: > Dear community, > > Discussion about 3rd party dependencies took place > and I think it is time to vote if we agreed to include > swagger dependency to the Ignite 3 or not. > > The e

Re: [VOTE] Add swagger dependency to Ignite 3

2022-05-25 Thread Alexander Polovtcev
+1 from me, I've seen many projects using this approach and I personally find it quite useful On Wed, May 25, 2022 at 5:54 PM Andrey Gura wrote: > Ilya, > > are there any alternatives to Swagger that you could recommend that > don't have the mentioned drawback? > > It seems that OPen API itself

Re: [DISCUSSION] Add additional 3rd party libraries to Ignite 3 Code style and practices

2022-05-25 Thread Andrey Gura
Why couldn't the handlers be annotated? I think Kirill Gusakov (as the feature contributor) can give some ideas about what and how should be annotated. This may require some tweaking. On Wed, May 25, 2022 at 6:06 PM Aleksandr Pakhomov wrote: > > Hi Alexander, > > Yes, swagger allows to annotate

Re: [DISCUSSION] Add additional 3rd party libraries to Ignite 3 Code style and practices

2022-05-25 Thread Aleksandr Pakhomov
Hi Alexander, Yes, swagger allows to annotate classes and then the spec will be generated. But here is a question. What classes should we annotade? Web framework brings the convention about how to write an endpoint and what to annotate. Our own REST server implementation does not. It is ju

Re: [DISCUSSION] Add additional 3rd party libraries to Ignite 3 Code style and practices

2022-05-25 Thread Andrey Gura
Agree with Alexander. I ask the same question in the vote thread. On Wed, May 25, 2022 at 5:47 PM Alexander Polovtcev wrote: > > Aleksandr, > > Can we use these annotations without the micronaut dependencies? If yes, > why do we need micronaut at all? > > On Mon, May 23, 2022 at 5:34 PM Aleksandr

Re: [VOTE] Add swagger dependency to Ignite 3

2022-05-25 Thread Andrey Gura
Ilya, are there any alternatives to Swagger that you could recommend that don't have the mentioned drawback? It seems that OPen API itself doesn't define primitive and wrapped types because such information is language/runtime/etc specific. Maybe this problem will be addressed in the future. On

Re: [DISCUSSION] Add additional 3rd party libraries to Ignite 3 Code style and practices

2022-05-25 Thread Alexander Polovtcev
Aleksandr, Can we use these annotations without the micronaut dependencies? If yes, why do we need micronaut at all? On Mon, May 23, 2022 at 5:34 PM Aleksandr Pakhomov wrote: > Yes, swagger-core has its own set of annotations [1] > > [1] > https://github.com/swagger-api/swagger-core/wiki/Swagge

Re: [VOTE] Add micronaut dependency to Ignite 3

2022-05-25 Thread Andrey Gura
-1 (binding) from me. Because (if I understood correctly) the main value of the IEP-87 is the possibility to generate API specification and Swagger annotations is enough for this purpose I don't see reasons for these dependencies. We already have our own controllers for REST-like API's implementat

Re: [DISCUSSION] Add additional 3rd party libraries to Ignite 3 Code style and practices

2022-05-25 Thread Andrey Gura
> The main functionality of micronaut framework is REST, so this library is scanned for vulnerabilities regularly and fixes them asap (looking to [1] it takes about a week). I don't think that Ignite REST server implementation will be scanned as regular as micronaut and issues will be fixed as qui

Re: [DISCUSSION] IEP-88: CLI Tool

2022-05-25 Thread Andrey Gura
Aleksandr, Both proposed options look good to me because both cases assume that a user must express their intent explicitly. On Thu, May 19, 2022 at 10:53 AM Aleksandr Pakhomov wrote: > > I got it. What do you think about this proposal: > > - “ignite” prints help > - “ignite shell” enters REP

Re: [DISCUSS] Query API for Ignite 3.0

2022-05-25 Thread Andrey Gura
Andrey, there is no IEP for Java API for SQL and would be great to have it. I'll create the IEP soon. On Fri, May 20, 2022 at 1:56 PM Andrey Mashenkov wrote: > > JFYI. we have merged the initial version of SQL public API [1] and are > going to implement it in epic [2] and I've created few ticket