Re: [VOTE] Deprecate and remove last-column-id

2024-11-25 Thread Fokko Driesprong
While counting the votes, I realized that I didn't vote explicitly myself. +1 from my end as well :) We have 13 votes, of which 7 are binding. I'll go ahead and merge the PR. Thanks everyone! I also raised PRs at PyIceberg and Iceberg-Rust

Re: [DISCUSS] Hive Support

2024-11-25 Thread Péter Váry
Let's separate out the discussion of the 2 modules: - hive-metastore - we definitely need the implementation and the tests here, as we want to be able to progress with features like views without waiting for a Hive release. So we need to move forward to Hive 4 now, and keep the code in place - hive

Re: [DISCUSS] PyIceberg 0.8.1 release

2024-11-25 Thread Kevin Liu
Hey folks, I started working on the 0.8.1 release, using the updated "how to release" docs ( https://github.com/apache/iceberg-python/blob/main/mkdocs/docs/how-to-release.md ) Here are the 9 commmits I propose to be included in this next release https://github.com/apache/iceberg-python/pull/1369

[ACTION REQUIRED] Removal of v3 artifact actions on December 5th

2024-11-25 Thread Jacob Wujciak
Hello Everyone! I am writing to inform you of the imminent removal of the v3 artifact actions that was announced in [1]. Both actions/upload-artifact@v3* and actions/download-artifact@v3* will stop working in 10 days, on December 5, 2024! According to a quick code search this project is using one

Re: [DISCUSS] Hive Support

2024-11-25 Thread Ayush Saxena
Hi Peter, Thanks for bringing this to our attention. >From my side, I have a say only on the code that resides in the Hive repository. I am okay with the first approach, as we are already following it for the most part. Whether Iceberg keeps or drops the code shouldn’t have much impact on us. (I

Re: [PROPOSAL] Store Iceberg build scans on ASF Develocity (ge.apache.org)

2024-11-25 Thread Jean-Baptiste Onofré
Let me check with infra if we can have non authenticated ge. Le lun. 25 nov. 2024 à 19:47, Robert Stupp a écrit : > The interesting part of build-scans is to have those even for CI runs on > PRs - to get more insights into the build/CI run. > > But with a GH secret, as required by ge.apache.org,

Re: [ACTION REQUIRED] Removal of v3 artifact actions on December 5th

2024-11-25 Thread Kevin Liu
Hey folks, I did a code search for both `actions/upload-artifact` and `actions/download-artifact` in the related iceberg repos. * https://grep.app/search?q=actions/upload-artifact%40v3&filter[repo.pattern][0]=apache/iceberg * https://grep.app/search?q=actions/download-artifact&filter[repo.pattern]

Re: [VOTE] Add Variant type to Iceberg Spec

2024-11-25 Thread Russell Spitzer
I'm +1, 1. I don't think we are going to change our decision on whether to include variants based on the timing of Parquet ratification 2. We aren't going to formally close V3 Spec yet, so if we do end up in a situation where we want to close the spec and Parquet has not removed the tag, we can re

Re: [PROPOSAL] Store Iceberg build scans on ASF Develocity (ge.apache.org)

2024-11-25 Thread Robert Stupp
The interesting part of build-scans is to have those even for CI runs on PRs - to get more insights into the build/CI run. But with a GH secret, as required by ge.apache.org, you cannot have have that, because then you would have to give all CI jobs access to secrets --> pwn [1]. That's the re

Re: [DISCUSS] Hive Support

2024-11-25 Thread Wing Yew Poon
For the Hive runtime, would it be feasible for the Hive community to contribute a suite of tests to the Iceberg repo that can be run with dependencies from the latest Hive release (Hive 4.x), and then update them from time to time as appropriate? The purpose of this suite would be to test integrati

Re: [PROPOSAL] Store Iceberg build scans on ASF Develocity (ge.apache.org)

2024-11-25 Thread Eduard Tudenhöfner
I think that's a good idea, so +1 from my side. On Mon, Nov 25, 2024 at 11:10 AM Jean-Baptiste Onofré wrote: > Hi folks, > > The ASF is hosting a Gradle Develocity instance where we can store our > build scans. > > It's hosted on https://ge.apache.org. > Several projects are using it (Apache Bea

Re: [PROPOSAL] Store Iceberg build scans on ASF Develocity (ge.apache.org)

2024-11-25 Thread Robert Stupp
It's tricky - have to use a mixture actually, as I notes in https://github.com/apache/polaris/pull/475#issuecomment-2497792648 : "Apache's instance rejects unauthenticated build scans, which is always the case for PR CI runs (no secrets in those GH workflows). So I think it's fine to let CI run

[PROPOSAL] Store Iceberg build scans on ASF Develocity (ge.apache.org)

2024-11-25 Thread Jean-Baptiste Onofré
Hi folks, The ASF is hosting a Gradle Develocity instance where we can store our build scans. It's hosted on https://ge.apache.org. Several projects are using it (Apache Beam, Apache Pekko, etc). Build scans collect information about a build, including the actual output of failed tests. It's con

Re: [PROPOSAL] Store Iceberg build scans on ASF Develocity (ge.apache.org)

2024-11-25 Thread Jean-Baptiste Onofré
We are using it in Apache Beam via this configuration: develocity { server = "https://ge.apache.org"; buildScan { uploadInBackground = !isCi publishing.onlyIf { it.isAuthenticated } obfuscation { ipAddresses { addresses -> addresses.map { "0.0.0.0" } } } } } and using

Re: [VOTE] Add Variant type to Iceberg Spec

2024-11-25 Thread Jean-Baptiste Onofré
I second Russell here. I think it makes sense to add variant type to V3 spec, even if the implementation details will come later. So +1 to add in the spec. Regards JB On Mon, Nov 25, 2024 at 6:21 PM Russell Spitzer wrote: > > I'm +1, > > 1. I don't think we are going to change our decision on w

Re: [ACTION REQUIRED] Removal of v3 artifact actions on December 5th

2024-11-25 Thread Jean-Baptiste Onofré
Hi Kevin I did a quick search and I have the same feedback as you: only iceberg-python is impacted. Thanks for the PR ! Regards JB On Mon, Nov 25, 2024 at 9:03 PM Kevin Liu wrote: > > Hey folks, > > I did a code search for both `actions/upload-artifact` and > `actions/download-artifact` in th

Re: [VOTE] Add Variant type to Iceberg Spec

2024-11-25 Thread Péter Váry
+1 from my side. I don't think we should be blocked on Parquet's finalization On Tue, Nov 26, 2024, 02:48 Xavier Bai wrote: > +1, not-binding > > Russell Spitzer 于2024年11月26日周二 01:21写道: > >> I'm +1, >> >> 1. I don't think we are going to change our decision on whether to >> include variants bas

Re: [VOTE] Add Variant type to Iceberg Spec

2024-11-25 Thread Xavier Bai
+1, not-binding Russell Spitzer 于2024年11月26日周二 01:21写道: > I'm +1, > > 1. I don't think we are going to change our decision on whether to include > variants based on the timing of Parquet ratification > 2. We aren't going to formally close V3 Spec yet, so if we do end up in a > situation where we

Re: [DISCUSS] Hive Support

2024-11-25 Thread Butao Zhang
Hi folks, Firstly Thanks Peter for bringing it up! I also think option 1 is a more reasonable solution right now, as we have developed lots of advanced iceberg features in hive repo, such as mor & cow & compaction, etc, and these feats are coupled with Hive core code base. Hive r