Re: [VOTE] Clarify "File System Tables" in the table spec

2024-08-01 Thread Eduard Tudenhöfner
+1 (non-binding) On Thu, Aug 1, 2024 at 6:52 AM Micah Kornfield wrote: > +1 (non-binding) > > On Wed, Jul 31, 2024 at 5:12 PM Ryan Blue wrote: > >> As promised in the discussion thread, I've opened a PR to clarify the >> "File System Tables" section and mark it deprecated since there appears to

Re: [Discussion] Versioned SQL UDFs (Catalog routines) in Iceberg

2024-08-01 Thread Ajantha Bhat
Thanks Walaa and Robert for the review on this. We didn't find any blocker for the spec. I will wait for a week and If no more review comments, I will raise a PR for spec addition next week. If anyone else is interested, please have a look at the proposal https://docs.google.com/document/d/1BDvOf

Re: [VOTE] Clarify "File System Tables" in the table spec

2024-08-01 Thread Fokko Driesprong
+1 (binding) Op do 1 aug 2024 om 09:57 schreef Eduard Tudenhöfner < etudenhoef...@apache.org>: > +1 (non-binding) > > On Thu, Aug 1, 2024 at 6:52 AM Micah Kornfield > wrote: > >> +1 (non-binding) >> >> On Wed, Jul 31, 2024 at 5:12 PM Ryan Blue wrote: >> >>> As promised in the discussion thread,

[DISCUSS] Changing namespace separator in REST spec

2024-08-01 Thread Eduard Tudenhöfner
Hey everyone, The REST spec currently uses *%1F* as the UTF-8 encoded namespace separator for multi-part namespaces. This causes issues

Re: [VOTE] Clarify "File System Tables" in the table spec

2024-08-01 Thread Russell Spitzer
+1 (Binding) On Thu, Aug 1, 2024 at 7:31 AM Fokko Driesprong wrote: > +1 (binding) > > Op do 1 aug 2024 om 09:57 schreef Eduard Tudenhöfner < > etudenhoef...@apache.org>: > >> +1 (non-binding) >> >> On Thu, Aug 1, 2024 at 6:52 AM Micah Kornfield >> wrote: >> >>> +1 (non-binding) >>> >>> On Wed,

[DISCUSS] Use iceberg-rust for PyIceberg Bucket Transform

2024-08-01 Thread Sung Yun
Hi everyone, This is something I've been mulling about for a while and I thought this would be the right forum to discuss this topic as a follow up to a similar topic discussion thread on using python bindings from iceberg-rust to support pyiceberg. As soon as we released 0.7.0 which supports wri

Re: [DISCUSS] Changing namespace separator in REST spec

2024-08-01 Thread Eduard Tudenhöfner
Here's the PR that bumps Jetty and the Servlet API and reproduces #10338 but it unfortunately requires to be built/executed with JDK17. On Thu, Aug 1, 2024 at 2:59 PM Eduard Tudenhöfner wrote: > Hey e

Re: [VOTE] Clarify "File System Tables" in the table spec

2024-08-01 Thread Jack Ye
+1 (binding) -Jack On Thu, Aug 1, 2024 at 6:30 AM Russell Spitzer wrote: > +1 (Binding) > > On Thu, Aug 1, 2024 at 7:31 AM Fokko Driesprong wrote: > >> +1 (binding) >> >> Op do 1 aug 2024 om 09:57 schreef Eduard Tudenhöfner < >> etudenhoef...@apache.org>: >> >>> +1 (non-binding) >>> >>> On Thu

Re: [VOTE] Clarify "File System Tables" in the table spec

2024-08-01 Thread Daniel Weeks
Added comments to the PR to include a target removal version and appropriate alternative messaging. +1 (binding) On Thu, Aug 1, 2024 at 8:24 AM Jack Ye wrote: > +1 (binding) > > -Jack > > On Thu, Aug 1, 2024 at 6:30 AM Russell Spitzer > wrote: > >> +1 (Binding) >> >> On Thu, Aug 1, 2024 at 7:3

Re: [VOTE] Clarify "File System Tables" in the table spec

2024-08-01 Thread Yufei Gu
+1 (binding) Yufei On Thu, Aug 1, 2024 at 8:33 AM Daniel Weeks wrote: > Added comments to the PR to include a target removal version and > appropriate alternative messaging. > > +1 (binding) > > On Thu, Aug 1, 2024 at 8:24 AM Jack Ye wrote: > >> +1 (binding) >> >> -Jack >> >> On Thu, Aug 1, 20

Re: [DISCUSS] Changing namespace separator in REST spec

2024-08-01 Thread Yufei Gu
+1 for replacing it to be compatible with the new Servlet spec. Yufei On Thu, Aug 1, 2024 at 7:02 AM Eduard Tudenhöfner wrote: > Here's the PR that bumps > Jetty and the Servlet API and reproduces #10338 >

Re: [DISCUSS] Changing namespace separator in REST spec

2024-08-01 Thread Robert Stupp
How is compatibility with older servers guaranteed? On 01.08.24 14:59, Eduard Tudenhöfner wrote: Hey everyone, The REST spec currently uses *%1F* as the UTF-8 encoded nam

Re: [VOTE] Clarify "File System Tables" in the table spec

2024-08-01 Thread Robert Stupp
+1 (nb) On 01.08.24 18:17, Yufei Gu wrote: +1 (binding) Yufei On Thu, Aug 1, 2024 at 8:33 AM Daniel Weeks wrote: Added comments to the PR to include a target removal version and appropriate alternative messaging. +1 (binding) On Thu, Aug 1, 2024 at 8:24 AM Jack Ye wrote:

Re: [VOTE] Clarify "File System Tables" in the table spec

2024-08-01 Thread Ryan Blue
Adding my own +1 On Thu, Aug 1, 2024 at 9:52 AM Robert Stupp wrote: > +1 (nb) > On 01.08.24 18:17, Yufei Gu wrote: > > +1 (binding) > Yufei > > > On Thu, Aug 1, 2024 at 8:33 AM Daniel Weeks wrote: > >> Added comments to the PR to include a target removal version and >> appropriate alternative m

Re: [VOTE] Clarify "File System Tables" in the table spec

2024-08-01 Thread Steven Wu
+1 (binding) On Thu, Aug 1, 2024 at 10:16 AM Ryan Blue wrote: > Adding my own +1 > > On Thu, Aug 1, 2024 at 9:52 AM Robert Stupp wrote: > >> +1 (nb) >> On 01.08.24 18:17, Yufei Gu wrote: >> >> +1 (binding) >> Yufei >> >> >> On Thu, Aug 1, 2024 at 8:33 AM Daniel Weeks wrote: >> >>> Added commen

Re: [VOTE] Clarify "File System Tables" in the table spec

2024-08-01 Thread Amogh Jahagirdar
+1 (non-binding) On Thu, Aug 1, 2024 at 10:22 AM Steven Wu wrote: > +1 (binding) > > On Thu, Aug 1, 2024 at 10:16 AM Ryan Blue > wrote: > >> Adding my own +1 >> >> On Thu, Aug 1, 2024 at 9:52 AM Robert Stupp wrote: >> >>> +1 (nb) >>> On 01.08.24 18:17, Yufei Gu wrote: >>> >>> +1 (binding) >>>

Re: [Discussion] Versioned SQL UDFs (Catalog routines) in Iceberg

2024-08-01 Thread Ryan Blue
I just looked through the proposal and added comments. I think it would be helpful to also have a design doc that covers the choices from the draft spec. For instance, the choice to enumerate all possible function input struts rather than allowing generics and varargs. Here’s a quick summary of my

Re: [DISCUSS] Spec clarifications on reading/writing Identity partitioned columns

2024-08-01 Thread Ryan Blue
I think especially with support for default values, it's important for the writer to always produce the column. Otherwise things that would arguably be safe are confusing and potentially return incorrect values. For instance, moving a file from a spec with an identity partition to one that drops th

Re: [DISCUSS] Use iceberg-rust for PyIceberg Bucket Transform

2024-08-01 Thread Ryan Blue
In general, I think the idea of using iceberg-rust more from PyIceberg is great. I think it will be a good path to pushing more things down to native code. What are the trade-offs of doing it this way? Is it that we would introduce a hard dependency on iceberg-rust? Is that a risk that could make

Unable to merge CDC into iceberg table

2024-08-01 Thread §æ §
Hi team, Can you please review this and guide me?  https://github.com/apache/iceberg/issues/8333#issuecomment-2261744910I have tried a bunch of options but nothing seems to work. Would really appreciate any path forward. Regards,Sandeep | | | | | | | | | | | Unable to merge CDC data

Re: [VOTE] Drop Java 8 support in Iceberg 1.7.0

2024-08-01 Thread Piotr Findeisen
Hi Thank you all for your participation. This is the summary of votes binding +1: 6 binding -1: 0 non-binding +1: 10 non-binding -1: 1 If i am not mistaken, this means we concluded the vote as 'yes' for dropping Java 8 support in 1.7.0 release. I wish we had unanimous decision, but I am aware

Re: [VOTE] Clarify "File System Tables" in the table spec

2024-08-01 Thread John Zhuge
+1 (non-binding) On Thu, Aug 1, 2024 at 10:55 AM Amogh Jahagirdar <2am...@gmail.com> wrote: > +1 (non-binding) > > On Thu, Aug 1, 2024 at 10:22 AM Steven Wu wrote: > >> +1 (binding) >> >> On Thu, Aug 1, 2024 at 10:16 AM Ryan Blue >> wrote: >> >>> Adding my own +1 >>> >>> On Thu, Aug 1, 2024 at

Re: [VOTE] Clarify "File System Tables" in the table spec

2024-08-01 Thread Steve Zhang
+1 (non-binding) Thanks, Steve Zhang > On Aug 1, 2024, at 2:25 PM, John Zhuge wrote: > > +1 (non-binding) > > On Thu, Aug 1, 2024 at 10:55 AM Amogh Jahagirdar <2am...@gmail.com > > wrote: >> +1 (non-binding) >> >> On Thu, Aug 1, 2024 at 10:22 AM Steven Wu >

Re: [DISCUSS] Changing namespace separator in REST spec

2024-08-01 Thread Ryan Blue
I think the simplest way to preserve compatibility is to allow this to be configured on the client and by the config route, and fall back to the current value, 0x1f. Another option is to introduce a set of v2 endpoints that use a different separator character. I prefer the first option since the on

Re: [EXTERNAL] Re: Iceberg-arrow vectorized read bug

2024-08-01 Thread Lessard, Steve
Hi Amogh, Do you think you could have another look at this issue or point me to someone who might be able to help me identify to the root cause and the correct fix? From: Lessard, Steve Date: Monday, July 29, 2024 at 5:46 PM To: dev@iceberg.apache.org , Amogh Jahagirdar <2am...@gmail.com> Cc

Re: [DISCUSS] Changing namespace separator in REST spec

2024-08-01 Thread Yufei Gu
+1 on the first option. We may not overly use the config endpoint, but it'd be suitable in this case. We can introduce a new field like this: namespace.separator=%2e Yufei On Thu, Aug 1, 2024 at 3:46 PM Ryan Blue wrote: > I think the simplest way to preserve compatibility is to allow this to