Re: CDC Merge Failing - https://github.com/apache/iceberg/issues/8333

2023-12-15 Thread Harshith Bolar
Hi Ryan, We have verified that the issue exists even after upgrading to Spark 3.5 and Iceberg 1.4.2. And explicitly casting the columns to String doesn't seem to help either. The error goes away when we downgrade to Iceberg 1.0.0 and reappears in 1.1.0. So, we're thinking a bug was possibly introd

Re: Pagination for List APIs in the REST spec

2023-12-15 Thread Ryan Blue
+1 for this approach I think it's good to use query params because it can be backward-compatible with the current behavior. If you get more than the limit back, then the service probably doesn't support pagination. And if a client doesn't support pagination they get the same results that they woul

Re: Pagination for List APIs in the REST spec

2023-12-15 Thread Micah Kornfield
Just to clarify and add a small suggestion: The behavior with no additional parameters requires the operations to happen as they do today for backwards compatibility (i.e either all responses are returned or a failure occurs). For new parameters, I'd suggest an opaque start token (instead of spec

Re: Pagination for List APIs in the REST spec

2023-12-15 Thread Daniel Weeks
I agree that we want to include this feature and I raised similar concerns to what Micah already presented in talking with Ryan. For backward compatibility, just adding a start and limit implies a deterministic order, which is not a current requirement of the REST spec. Also, we need to consider