Re: [DISCUSS] Automatic Code Formatting / Code Style / Enforcing Code Style

2022-07-27 Thread Eduard Tudenhoefner
Hey everyone, Google Java Format + Spotless integration have been merged as part of https://github.com/apache/iceberg/pull/5266. The big bang reformatting (aka *spotlessApply*) will happen as part of https://github.com/apache/iceberg/pull/5312 and once this PR is merged, please perform the follow

Re: [DISCUSS] Automatic Code Formatting / Code Style / Enforcing Code Style

2022-07-27 Thread Steven Wu
Eduard, thank you for driving this effort! Great work! On Wed, Jul 27, 2022 at 11:11 AM Eduard Tudenhoefner wrote: > Hey everyone, > > Google Java Format + Spotless integration have been merged as part of > https://github.com/apache/iceberg/pull/5266. > > The big bang reformatting (aka *spotless

Re: [DISCUSS] Automatic Code Formatting / Code Style / Enforcing Code Style

2022-07-27 Thread Eduard
Unsubscribe On Wed, Jul 27, 2022 at 11:11 Eduard Tudenhoefner wrote: > Hey everyone, > > Google Java Format + Spotless integration have been merged as part of > https://github.com/apache/iceberg/pull/5266. > > The big bang reformatting (aka *spotlessApply*) will happen as part of > https://githu

Re: [DISCUSS] Automatic Code Formatting / Code Style / Enforcing Code Style

2022-07-27 Thread Anton Okolnychyi
I am late to the discussion, but I would like to express my opinion. As someone who deeply cares about the code consistency and leaves a lot of style-related nits, I am definitely happy to see efforts to simplify the life of the reviewers and automate the formatting process. Explaining the code