That's correct Ryan. The Google style is what can be applied across tools
and Spotless is the tool that we use to check and *apply* that style (and
also auto-apply the license header). The *apply* part is the important
piece that Checkstyle for example is missing (as it's tedious to manually
apply
+1 (binding)
- verified checksum, license, RAT (same issue as reported)
- ran build, unit test, AWS integration test (Java 8, Amazon corretto)
- did some benchmarking and internal release test verification with AWS EMR
Spark 3.2
Best,
Jack Ye
On Thu, Jul 14, 2022 at 5:24 PM Jahagirdar, Amogh
+1 (non-binding)
Verified sigs, sums, license (same #5262), build and test with
OpenJDK 1.8.0_332.
Ignore the following unit test failure:
org.apache.iceberg.aws.s3.TestS3FileIO > testPrefixDelete FAILED
software.amazon.awssdk.services.s3.model.S3Exception: null (Service:
S3, Status Code: 50
+1 (binding)
> On Jul 12, 2022, at 9:12 PM, Ryan Blue wrote:
>
> Hi everyone,
>
> I propose the following RC to be released as the official Apache Iceberg
> 0.14.0 release.
>
> The commit id is 6d2edd6284ebc5301dbe45376a31ca8316852a77
> * This corresponds to the tag: apache-iceberg-0.14.0-rc
+1 (non-binding)
- Verified signature
- Verified checksum
- Rat check
- Could not find Apache license headers on iceberg-build.properties (
as mentioned by Ryan)
- Ran tests
- Same error mentioned by John:
org.apache.iceberg.aws.s3.TestS3FileIO > testPrefixDel
