SQL compatibility of Iceberg Expressions

2020-09-17 Thread Shardul Mahadik
Hi all, I noticed that Iceberg's predicates are not compatible with SQL predicates when it comes to handling NULL values. In SQL, if any of the operands of a scalar comparison predicate is NULL, then the resultant truth value of the predicate is UNKNOWN. e.g. `SELECT NULL != 1` will return a NULL

Connection leak (unclosed reader) leading to s3a timeout exceptions

2020-09-17 Thread Sud
HI Iceberg-dev's I am investigating the connection leak issue we are seeing after upgrading to the latest iceberg. I have narrowed down investigation to following PR and testing fix now https://github.com/apache/iceberg/commit/7060c928390c59e24dc207ec86f99132f6c1a828#diff-9726b2a5391d8755f6c5c849

Re: Connection leak (unclosed reader) leading to s3a timeout exceptions

2020-09-17 Thread Sud
submitted PR with fix please review https://github.com/apache/iceberg/pull/1474/files On Thu, Sep 17, 2020 at 3:56 PM Sud wrote: > HI Iceberg-dev's > > I am investigating the connection leak issue we are seeing after upgrading > to the latest iceberg. > I have narrowed down investigation to fol

Re: Connection leak (unclosed reader) leading to s3a timeout exceptions

2020-09-17 Thread Ryan Blue
Thanks for the quick fix! On Thu, Sep 17, 2020 at 4:25 PM Sud wrote: > submitted PR with fix please review > > https://github.com/apache/iceberg/pull/1474/files > > On Thu, Sep 17, 2020 at 3:56 PM Sud wrote: > >> HI Iceberg-dev's >> >> I am investigating the connection leak issue we are seeing