Re: LongLiteral to DateLiteral

2020-02-20 Thread Ryan Blue
Sounds reasonable to me. Can you open a PR to add the conversion? On Wed, Feb 19, 2020 at 2:40 PM Vlad Rozov wrote: > AFAIK, Presto uses 4 bytes for DateType as well as for IntegerType for its > internal representation, but java signature is Long, so from an API point > of view, it is long. When

Re: LongLiteral to DateLiteral

2020-02-20 Thread Vlad Rozov
https://github.com/apache/incubator-iceberg/pull/815 Thank you, Vlad On 2020/02/20 17:55:35, Ryan Blue wrote: > Sounds reasonable to me. Can you open a PR to add the conversion? > > On Wed, Feb 19, 2020 at 2:40 PM Vlad Rozov wrote: > > > AFAIK, Presto uses 4 bytes for DateType as well as fo

Re: Static import

2020-02-20 Thread Vlad Rozov
Please review https://github.com/apache/incubator-iceberg/pull/816. Thank you, Vlad On 2020/02/19 20:09:45, Ryan Blue wrote: > Sounds fine to me. Can you open a PR for this? > > On Wed, Feb 19, 2020 at 11:40 AM Vlad Rozov wrote: > > > Hi Ryan, > > > > Currently, it is a cherry-pick of class