Re: Spec Clarification: Partition Spec equality

2023-11-21 Thread Micah Kornfield
Tried to put together: https://github.com/apache/iceberg/pull/9125 to cover this. On Sun, Nov 5, 2023 at 10:41 AM Ryan Blue wrote: > Right now, both should be guaranteed. The library will only create a new > spec identifier if there isn't an existing spec that meets the second > equality definit

Re: Spec Clarification: Partition Spec equality

2023-11-05 Thread Ryan Blue
Right now, both should be guaranteed. The library will only create a new spec identifier if there isn't an existing spec that meets the second equality definition. That's implemented here: https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/TableMetadata.java#L1537-L15

Spec Clarification: Partition Spec equality

2023-11-03 Thread Micah Kornfield
Hello Iceberg Dev, The Iceberg specification for matching delete files with data files during scan planning states : "The data file’s partition (both spec and partition values) is equal to the delete file’s partition" Equality of partition specs appears slightly ambiguous (apologies if I missed t