Re: Review request for a SnapshotManager change

2022-12-09 Thread Ryan Blue
Done. On Fri, Dec 9, 2022 at 1:30 AM Gabor Kaszab wrote: > Hey Committers, > > I have a PR that has been open for a while and I'm wondering if any of the > committers have some spare cycles to take a look at? > This change is related to SnapshotManager that is currently using an > internal Trans

Re: Review request

2022-03-02 Thread Ryan Blue
Looks great. Sorry that I missed this one to review! On Wed, Mar 2, 2022 at 1:31 AM OpenInx wrote: > Thanks Peter for the great work. Just added my comments. > > On Wed, Mar 2, 2022 at 4:20 PM Peter Vary > wrote: > >> Hi Team, >> >> I have a PR (https://github.com/apache/iceberg/pull/4218) wait

Re: Review request

2022-03-02 Thread OpenInx
Thanks Peter for the great work. Just added my comments. On Wed, Mar 2, 2022 at 4:20 PM Peter Vary wrote: > Hi Team, > > I have a PR (https://github.com/apache/iceberg/pull/4218) waiting for > review where with basically a 1 liner change we can improve the performance > of the GenericReader clas