Re: Iceberg build and Nessie

2021-06-21 Thread Peter Vary
+1 for option 3 We do similar things for Hive3 tests where only jdk8 is supported. > On Jun 14, 2021, at 23:02, Ryan Murray wrote: > > Thanks Jack/Ryan for the feedback! > > I am happy to go with option 3 if that is what people agree on. Its the > simplest change. > > To be clear: We will jus

Re: Iceberg build and Nessie

2021-06-14 Thread Ryan Murray
Thanks Jack/Ryan for the feedback! I am happy to go with option 3 if that is what people agree on. Its the simplest change. To be clear: We will just skip tests in the Nessie module on Java8. This will still create the jars for releases and still run tests for Java11. I will wait a day or two to

Re: Iceberg build and Nessie

2021-06-14 Thread Ryan Blue
I would also vote for option 3. That seems like the easiest way to go if the Nessie server can't run in JDK8. Assuming that people have multiple JDKs available seems brittle to me, too. And using a container seems like a bit more development work in the Iceberg build. How long can we continue runni

Re: Iceberg build and Nessie

2021-06-14 Thread Jack Ye
My thinking is that currently we already have CI tasks for JDK 8 and 11 separately, so it would be sufficient to only run build on JDK8 and run build and test on JDK11, which leads to option 3. For option 1, I think people do mostly have JDK 11, but might not want to have 8 and 11 at the same time