Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-09 Thread Carl Steinbach
I am withdrawing RC2 from voting because of issues that were found during testing. RC3 will follow shortly. Thanks, everyone, for your help testing RC2! - Carl On Mon, Aug 9, 2021 at 1:44 PM Szehon Ho wrote: > Got it, I somehow thought changes were manually cherry-picked, thanks for > clarific

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-09 Thread Szehon Ho
Got it, I somehow thought changes were manually cherry-picked, thanks for clarification. Thanks Szehon > On 9 Aug 2021, at 13:34, Ryan Blue wrote: > > Szehon, I think that should make it because the RC will come from master. > > On Mon, Aug 9, 2021 at 12:56 PM Szehon Ho wrote: > If it’s easy

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-09 Thread Wing Yew Poon
https://github.com/apache/iceberg/pull/2954 should be ready to merge. The CI passed. On Mon, Aug 9, 2021 at 9:08 AM Wing Yew Poon wrote: > Ryan, > Thanks for the review. Let me look into implementing your refactoring > suggestion. > - Wing Yew > > > On Mon, Aug 9, 2021 at 8:41 AM Ryan Blue wro

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-09 Thread Ryan Blue
Szehon, I think that should make it because the RC will come from master. On Mon, Aug 9, 2021 at 12:56 PM Szehon Ho wrote: > If it’s easy, would it make sense to include Russell’s fix as well for > Metadata tables query , as it affects Spark 3.1 (a regression from Spark > 3.0)? https://github.c

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-09 Thread Szehon Ho
If it’s easy, would it make sense to include Russell’s fix as well for Metadata tables query , as it affects Spark 3.1 (a regression from Spark 3.0)? https://github.com/apache/iceberg/pull/2877/files The issue : https://github.com/apache/iceberg/issues/2783 was at some point marked for 0.12 re

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-09 Thread Ryan Blue
Thanks for pointing that one out, Jack! That would be good to get in as well. On Mon, Aug 9, 2021 at 11:02 AM Jack Ye wrote: > If we are considering recutting the branch, please also include this PR > https://github.com/apache/iceberg/pull/2943 which fixes the validation > when creating a schema

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-09 Thread Jack Ye
If we are considering recutting the branch, please also include this PR https://github.com/apache/iceberg/pull/2943 which fixes the validation when creating a schema with identifier fields, thank you! -Jack Ye On Mon, Aug 9, 2021 at 9:08 AM Wing Yew Poon wrote: > Ryan, > Thanks for the review.

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-09 Thread Wing Yew Poon
Ryan, Thanks for the review. Let me look into implementing your refactoring suggestion. - Wing Yew On Mon, Aug 9, 2021 at 8:41 AM Ryan Blue wrote: > Yeah, I agree. We should fix this for the 0.12.0 release. That said, I > plan to continue testing this RC because it won't change that much since

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-09 Thread Ryan Blue
Yeah, I agree. We should fix this for the 0.12.0 release. That said, I plan to continue testing this RC because it won't change that much since this affects the Spark extensions in 3.1. Other engines and Spark 3.0 or older should be fine. I left a comment on the PR. I think it looks good, but we s

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-08 Thread Carl Steinbach
Hi Wing Yew, I will create a new RC once this patch is committed. Thanks. - Carl On Sat, Aug 7, 2021 at 4:29 PM Wing Yew Poon wrote: > Sorry to bring this up so late, but this just came up: there is a Spark > 3.1 (runtime) compatibility issue (not found by existing tests), which I > have a fi

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-07 Thread Wing Yew Poon
Sorry to bring this up so late, but this just came up: there is a Spark 3.1 (runtime) compatibility issue (not found by existing tests), which I have a fix for in https://github.com/apache/iceberg/pull/2954. I think it would be really helpful if it can go into 0.12.0. - Wing Yew On Fri, Aug 6, 20

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-06 Thread Jack Ye
+1 (non-binding) Verified release test and AWS integration test, issue found in test but not blocking for release (https://github.com/apache/iceberg/pull/2948) Verified Spark 3.1 and 3.0 operations and new SQL extensions and procedures on EMR. Thanks, Jack Ye On Fri, Aug 6, 2021 at 1:19 AM Kyle

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-06 Thread Kyle Bendickson
+1 (binding) I verified: - KEYS signature & checksum - ./gradlew clean build (tests, etc) - Ran Spark jobs on Kubernetes after building from the tarball at https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-0.12.0-rc2/ - Spark 3.1.1 batch jobs against both Hadoop and Hive tables

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-05 Thread Szehon Ho
+1 (non-binding) * Verify Signature Keys * Verify Checksum * dev/check-license * Build * Run tests (though some timeout failures, on Hive MR test..) Thanks Szehon On Thu, Aug 5, 2021 at 2:23 PM Daniel Weeks wrote: > +1 (binding) > > I verified sigs/sums, license, build, and test > > -Dan > > O

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-05 Thread Daniel Weeks
+1 (binding) I verified sigs/sums, license, build, and test -Dan On Wed, Aug 4, 2021 at 2:53 PM Ryan Murray wrote: > After some wrestling w/ Spark I discovered that the problem was with my > test. Some SparkSession apis changed. so all good here now. > > +1 (non-binding) > > On Wed, Aug 4, 202

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-04 Thread Ryan Murray
After some wrestling w/ Spark I discovered that the problem was with my test. Some SparkSession apis changed. so all good here now. +1 (non-binding) On Wed, Aug 4, 2021 at 11:29 PM Ryan Murray wrote: > Thanks for the help Carl, got it sorted out. The gpg check now works. For > those who were in

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-04 Thread Ryan Murray
Thanks for the help Carl, got it sorted out. The gpg check now works. For those who were interested I used a canned wget command in my history and it pulled the RC0 :-) Will have a PR to fix the Nessie Catalog soon. Best, Ryan On Wed, Aug 4, 2021 at 9:21 PM Carl Steinbach wrote: > Hi Ryan, > >

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-04 Thread Carl Steinbach
Hi Ryan, Can you please run the following command to see which keys in your public keyring are associated with my UID? % gpg --list-keys c...@apache.org pub rsa4096/5A5C7F6EB9542945 2021-07-01 [SC] 160F51BE45616B94103ED24D5A5C7F6EB9542945 uid [ultimate] Carl W. Steinbach

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-04 Thread Carl Steinbach
To make this easier for everyone else, here are the commands you need to run to verify the release tarball: curl https://dist.apache.org/repos/dist/dev/iceberg/KEYS -o KEYS gpg --import KEYS gpg --verify apache-iceberg-0.12.0.tar.gz.asc apache-iceberg-0.12.0.tar.gz And here's what I see when I ru

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-04 Thread Ryan Blue
Ryan, did you re-import the KEYS file? Carl's code signing key is in the linked KEYS file. On Wed, Aug 4, 2021 at 11:12 AM Ryan Murray wrote: > Hi all, > > Unfortunately I have to give -1 > > I had trouble w/ the keys: > > gpg: assuming signed data in 'apache-iceberg-0.12.0.tar.gz' > gpg: Signat

Re: [VOTE] Release Apache Iceberg 0.12.0 RC2

2021-08-04 Thread Ryan Murray
Hi all, Unfortunately I have to give -1 I had trouble w/ the keys: gpg: assuming signed data in 'apache-iceberg-0.12.0.tar.gz' gpg: Signature made Mon 02 Aug 2021 03:36:30 CEST gpg:using RSA key FAFEB6EAA60C95E2BB5E26F01FF0803CB78D539F gpg: Can't check signature: No public key A