Re: [DISCUSS] Forward compatibility and snapshot ID inheritance

2020-01-14 Thread Romin Parekh
43 PM > *To:* "Iceberg Dev List"; > *Cc:* "Ryan Blue"; > *Subject:* Re: [DISCUSS] Forward compatibility and snapshot ID inheritance > > +1 on feature flag in this case. > > I encourage everyone interested to take a look at the PR itself [1]. There > are a f

Re: [DISCUSS] Forward compatibility and snapshot ID inheritance

2020-01-14 Thread chenjunjiedada

Re: [DISCUSS] Forward compatibility and snapshot ID inheritance

2020-01-14 Thread Anton Okolnychyi
+1 on feature flag in this case. I encourage everyone interested to take a look at the PR itself [1]. There are a few open things to address, though. - Anton [1] - https://github.com/apache/incubator-iceberg/pull/675 > On 14 Jan 2020, at

Re: [DISCUSS] Forward compatibility and snapshot ID inheritance

2020-01-13 Thread Gautam
A feature flag sounds good to me with associated regression tests to pair along with each feature. Re: Snapshot Id Inheritance, would be good to update the spec with the change in metadata guarantees. -Gautam. On Mon, Jan 13, 2020 at 11:28 AM Ryan Blue wrote: > Hi everyone, > > Anton has a PR

Re: [DISCUSS] Forward compatibility and snapshot ID inheritance

2020-01-13 Thread Xabriel Collazo Mojica
+1 to having a feature flag mechanism that defaults to ‘compatible’ mode by default. I would suggest a robust test suite around this new feature, with a focus on not breaking existing behavior when in ‘compatible’ mode. Xabriel J Collazo Mojica | Sr Software Engineer | Adobe From: Ryan Blu