Re: PR: implementation of timestamp_ns and timestamptz_ns

2023-11-08 Thread Jacob Marble
Here is the second, smaller PR, touching only the API module. https://github.com/apache/iceberg/pull/9008 Running tests locally triggers a few failures in modules Spark and Flink, but I'm not sure what to do about those yet. On Wed, Nov 8, 2023 at 10:41 AM Jacob Marble wrote: > Per Ryan's sugg

Re: PR: implementation of timestamp_ns and timestamptz_ns

2023-11-08 Thread Jacob Marble
Per Ryan's suggestion, I'm breaking this up into smaller PRs. The first should be very non-controversial - the spec needs an update so that ORC types can be converted back to Iceberg types. https://github.com/apache/iceberg/pull/9007 On Tue, Nov 7, 2023 at 11:41 AM Jean-Baptiste Onofré wrote: >

Re: PR: implementation of timestamp_ns and timestamptz_ns

2023-11-07 Thread Jean-Baptiste Onofré
Hi Jacob, Thanks for the update. I will take a look. Regards JB NB: sorry guys, I was offline since last Thursday as we have been hit by Ciaran storm. We still don't have electricity and damages at home. Things should be better in the coming days. On Tue, Nov 7, 2023 at 6:00 PM Jacob Marble wr

PR: implementation of timestamp_ns and timestamptz_ns

2023-11-07 Thread Jacob Marble
Good morning Iceberg Dev-ers, I've worked through most of a first-pass review in this PR. Please take a look! https://github.com/apache/iceberg/pull/8971 -- Jacob Marble 🇺🇸 🇺🇦