@Anton OkolnychyiLooking forward to the pull
requests :-)
On Wed, Mar 18, 2020 at 3:38 AM Anton Okolnychyi
wrote:
> As Ryan noted, there are multiple cases when some files can be left orphan
> and we won’t be able to avoid all such cases. In our case, we are
> periodically listing locations
As Ryan noted, there are multiple cases when some files can be left orphan and
we won’t be able to avoid all such cases. In our case, we are periodically
listing locations and comparing the actual files to all files present in
metadata tables.
At some point, there was an agreement in the commu
Thanks for bringing this up, Ashish. The section of code that you point out
is *mostly* correct, but there is a case that we should fix. The reason I
say “mostly correct” is that it has correct behavior and has error handling
to ensure that as much of the work is done as possible.
Even if not all o
Hi Ashish
It's indeed a bug for my understanding, I read your idea about the
transaction hook. removing the data & manifest file
of expired snapshots should happen after writing version-hint file
(otherwise there will be some readers accessing
snapshots which we are deleting data files). so the h
Hi,
While using feature of Expire/RemoveSnapshots, I saw that the clean up
operation of files happens, after successful commit [1] of snapshot list
and update to `version-hint.text`, which means that in case of
intermittent/IOException from underlying store, we might end up leaving the
files on di
