回复: Discussion about applying spotless for scala code

2023-07-20 Thread Liu Xianyang
Thanks Ryan and community for the feedback. -Xianyang 发件人: Ryan Blue 发送时间: 2023年7月19日 17:44 收件人: dev@iceberg.apache.org 主题: Re: Discussion about applying spotless for scala code We talked about this more in the community sync today and came to the conclusion

Re: Discussion about applying spotless for scala code

2023-07-19 Thread Ryan Blue
of spaces and > line length. > > Thanks, > Xianyang > -- > *发件人:* Manu Zhang > *发送时间:* 2023年7月19日 0:59 > *收件人:* dev@iceberg.apache.org > *主题:* Re: Discussion about applying spotless for scala code > > Is this the right time to do so?

回复: Discussion about applying spotless for scala code

2023-07-18 Thread Liu Xianyang
收件人: dev@iceberg.apache.org 主题: Re: Discussion about applying spotless for scala code Is this the right time to do so? It will bring a lot of conflicts with open PRs and forked codebases. It also hides other commits when I do `Git Blame`. My two cents, Manu On Wed, Jul 19, 2023 at 12:24 AM

Re: Discussion about applying spotless for scala code

2023-07-18 Thread Manu Zhang
ut applying spotless for Scala code. > We need to get more advice since it will change a lot of files. We have > already applied spotless for Java code which helps developers easily follow > the code style. And also it makes better code management. I see there are > already some discussi

Discussion about applying spotless for scala code

2023-07-18 Thread Liu Xianyang
Hello everyone: I'd like the raise a discussion about applying spotless for Scala code. We need to get more advice since it will change a lot of files. We have already applied spotless for Java code which helps developers easily follow the code style. And also it makes better code manag