Re: Core changes for Flink Dynamic Iceberg Sink

Thanks Ryan! I totally missed those static method constructors (maybe because they are in an entirely different class). In that case, we don't need change (1) and (2). For SchemaUpdate, I agree we could implement the interface. The drawback is that it won't verify test results with the actual impl

Re: Core changes for Flink Dynamic Iceberg Sink

Max, Can you use the factory methods in Expressions rather than changing visibility? Also, I don’t think that making SchemaUpdate public is a good idea. It has a public interf

Core changes for Flink Dynamic Iceberg Sink

Hi, The Flink Dynamic Iceberg Sink requires a few iceberg-core class visibility changes, which I'd like to get your feedback on. Here is the diff: https://github.com/apache/iceberg/pull/13032/commits/1804b0ac4ff97c3c943463725e91a1e24b0f8c44 There are three visibility changes: Change 1: Make Nam