Re: [VOTE] Release Apache Iceberg 1.6.1 RC1

Working on it now. - Carl On Thu, Aug 22, 2024 at 5:13 AM Jean-Baptiste Onofré wrote: > Yeah, it makes sense (and it was what I expected to be honest :) ). > > Eduard already reviewed and merged, so I think we are good for a new > RC. I guess Carl will prepare a new one soon. > > Thanks ! > > R

Re: [VOTE] Release Apache Iceberg 1.6.1 RC1

Yeah, it makes sense (and it was what I expected to be honest :) ). Eduard already reviewed and merged, so I think we are good for a new RC. I guess Carl will prepare a new one soon. Thanks ! Regards JB On Thu, Aug 22, 2024 at 11:54 AM Driesprong, Fokko wrote: > > It was not correctly backport

Re: [VOTE] Release Apache Iceberg 1.6.1 RC1

Thanks Fokko, I've just reviewed/merged it. We should be good to do another RC. On Thu, Aug 22, 2024 at 11:54 AM Driesprong, Fokko wrote: > It was not correctly backported, I do think we want to add this since it > fixes a CVE as mentioned earlier. I've created a PR: > https://github.com/apache

Re: [VOTE] Release Apache Iceberg 1.6.1 RC1

It was not correctly backported, I do think we want to add this since it fixes a CVE as mentioned earlier. I've created a PR: https://github.com/apache/iceberg/pull/10988 Kind regards, Fokko Op do 22 aug 2024 om 11:35 schreef Jean-Baptiste Onofré : > Hi guys, > > FYI, the reason I mentioned ORC

Re: [VOTE] Release Apache Iceberg 1.6.1 RC1

Hi guys, FYI, the reason I mentioned ORC update is because the PR is "flagged" with milestone 1.6.1. So it's a bit surprising to not have it in 1.6.1. We should at least update the PR/issue removing the 1.6.1 milestone, else it would not be "accurate". Regards JB On Thu, Aug 22, 2024 at 12:04 A

Re: [VOTE] Release Apache Iceberg 1.6.1 RC1

Ah sorry I totally missed that message from JB mentioning ORC. I also didn't see the ORC update in the RC. On Thu, Aug 22, 2024 at 12:06 AM Piotr Findeisen wrote: > Hi Eduard, > > JB wrote > > For the record (maybe it helps users/reviewers), this release includes: >> - ORC 1.9.4 update >> - intr

Re: [VOTE] Release Apache Iceberg 1.6.1 RC1

Hi Eduard, JB wrote For the record (maybe it helps users/reviewers), this release includes: > - ORC 1.9.4 update > - introduce memory limit on ParallelIterable I can confirm ParallelIterable change, but i am not sure whether ORC update was part of the release. Best Piotr On Wed, 21 Aug 20

Re: [VOTE] Release Apache Iceberg 1.6.1 RC1

Hey Eduard, I think it relates to this PR. It contains a CVE and would be good to be backported. We wanted to include it in 1.6.1 if we needed another RC, but that didn't happen, so I think we didn't cherry-pick it to 1.6.x branch. Kind regards, Fokk

Re: [VOTE] Release Apache Iceberg 1.6.1 RC1

@Piotr can you please elaborate which ORC update you are referring to? Or did you mean the Avro update (which I think we were planning for 1.6.2)? On Tue, Aug 20, 2024 at 7:05 PM Piotr Findeisen wrote: > Hi > > -1 (non-binding) > > I verified source tarball matches the git tag (except it > lacks

Re: [VOTE] Release Apache Iceberg 1.6.1 RC1

Hi -1 (non-binding) I verified source tarball matches the git tag (except it lacks jitpack.yml, docs/ and 'examples/Convert table to Iceberg.ipynb'). However, i noted that source tarball verification is not part of https://iceberg.apache.org/how-to-release/#validating-a-source-release-candidate .

Re: [VOTE] Release Apache Iceberg 1.6.1 RC1

> TestHadoopCommits > testConcurrentFastAppends(File) FAILED I have seen this test a bit flaky before On Tue, Aug 20, 2024 at 6:31 AM Jean-Baptiste Onofré wrote: > +1 (non binding) > > I checked: > - download links are OK (both on dist and Maven Staging repo) > - build passed on the tag using J

Re: [VOTE] Release Apache Iceberg 1.6.1 RC1

+1 (non binding) I checked: - download links are OK (both on dist and Maven Staging repo) - build passed on the tag using JDK11, including the tests (I'm not able to reproduce Renjie's issue) - checksum and signature are good - ASF header present in expected files - no unexpected binary files foun

Re: [VOTE] Release Apache Iceberg 1.6.1 RC1

Hi, Carl: Thanks for driving this. I tried to run `./gradlew build` and one test failed: > Task :iceberg-core:test TestHadoopCommits > testConcurrentFastAppends(File) FAILED org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in org.apache.iceberg.hadoop.TestHadoo

[VOTE] Release Apache Iceberg 1.6.1 RC1

Hi Everyone, I propose that we release the following RC as the official Apache Iceberg 1.6.1 release. The commit ID is e18a2fe10214f5f3ffa0a317a28af8b2a619817a * This corresponds to the tag: apache-iceberg-1.6.1-rc1 * https://github.com/apache/iceberg/commits/apache-iceberg-1.6.1-rc1 * https://gi