[RESULT][VOTE] Merge guidelines for committing PRs

The vote passes: 5 +1 Binding Votes (Steven, Anton, Yufei, Amogh, Renjie) 3 +1 non-binding votes (Walaa, Dmitri, Micah) 2 -0 (Ryan and JB) I think the next step is to merge the PR [1] , could a committer help with this? Thanks, Micah [1] https://github.com/apache/iceberg/pull/10780 On Fri, Aug

Re: [VOTE] Merge guidelines for committing PRs

-0 (non binding) I'm not convinced it would help much but worth to see :) Regards JB On Wed, Aug 28, 2024 at 6:28 PM Micah Kornfield wrote: > > I propose to merge https://github.com/apache/iceberg/pull/10780 as a starting > place for describing community norms around merging/discussing PRs.

Re: [VOTE] Merge guidelines for committing PRs

-0 While I appreciate the motivation, I think that this is going to lead to more problems, not fewer. On Wed, Aug 28, 2024 at 10:54 PM Renjie Liu wrote: > +1 (binding) > > On Thu, Aug 29, 2024 at 8:59 AM Amogh Jahagirdar <2am...@gmail.com> wrote: > >> +1 (binding) >> >> On Wed, Aug 28, 2024 at

Re: [VOTE] Merge guidelines for committing PRs

+1 (binding) On Thu, Aug 29, 2024 at 8:59 AM Amogh Jahagirdar <2am...@gmail.com> wrote: > +1 (binding) > > On Wed, Aug 28, 2024 at 6:45 PM Yufei Gu wrote: > >> +1 (binding) >> Yufei >> >> >> On Wed, Aug 28, 2024 at 4:56 PM Anton Okolnychyi >> wrote: >> >>> +1 (binding) >>> >>> Thanks, Micah! >>

Re: [VOTE] Merge guidelines for committing PRs

+1 (binding) On Wed, Aug 28, 2024 at 6:45 PM Yufei Gu wrote: > +1 (binding) > Yufei > > > On Wed, Aug 28, 2024 at 4:56 PM Anton Okolnychyi > wrote: > >> +1 (binding) >> >> Thanks, Micah! >> >> ср, 28 серп. 2024 р. о 16:36 Dmitri Bourlatchkov >> пише: >> >>> +1 (nb) >>> >>> Cheers, >>> Dmitri.

Re: [VOTE] Merge guidelines for committing PRs

+1 (binding) Yufei On Wed, Aug 28, 2024 at 4:56 PM Anton Okolnychyi wrote: > +1 (binding) > > Thanks, Micah! > > ср, 28 серп. 2024 р. о 16:36 Dmitri Bourlatchkov > пише: > >> +1 (nb) >> >> Cheers, >> Dmitri. >> >> On Wed, Aug 28, 2024 at 12:29 PM Micah Kornfield >> wrote: >> >>> I propose to

Re: [VOTE] Merge guidelines for committing PRs

+1 (binding) Thanks, Micah! ср, 28 серп. 2024 р. о 16:36 Dmitri Bourlatchkov пише: > +1 (nb) > > Cheers, > Dmitri. > > On Wed, Aug 28, 2024 at 12:29 PM Micah Kornfield > wrote: > >> I propose to merge https://github.com/apache/iceberg/pull/10780 as a >> starting place for describing community

Re: [VOTE] Merge guidelines for committing PRs

+1 (nb) Cheers, Dmitri. On Wed, Aug 28, 2024 at 12:29 PM Micah Kornfield wrote: > I propose to merge https://github.com/apache/iceberg/pull/10780 as a > starting place for describing community norms around merging/discussing PRs. > > We've discussed this [1] and gone through a bunch of revision

Re: [VOTE] Merge guidelines for committing PRs

+1 (non-binding) On Wed, Aug 28, 2024 at 9:36 AM Steven Wu wrote: > +1 (binding) > > On Wed, Aug 28, 2024 at 9:29 AM Micah Kornfield > wrote: > >> I propose to merge https://github.com/apache/iceberg/pull/10780 as a >> starting place for describing community norms around merging/discussing PRs.

Re: [VOTE] Merge guidelines for committing PRs

+1 (binding) On Wed, Aug 28, 2024 at 9:29 AM Micah Kornfield wrote: > I propose to merge https://github.com/apache/iceberg/pull/10780 as a > starting place for describing community norms around merging/discussing PRs. > > We've discussed this [1] and gone through a bunch of revisions on the PR >

[VOTE] Merge guidelines for committing PRs

I propose to merge https://github.com/apache/iceberg/pull/10780 as a starting place for describing community norms around merging/discussing PRs. We've discussed this [1] and gone through a bunch of revisions on the PR to what is a minimal starting point for describing the merge process. The vote