Re: [VOTE] Allow Row-Lineage with Equality Deletes

2025-02-24 Thread Russell Spitzer
Ok We are all on the same page :) I'll finish up last reviewer's comments and merge. On Fri, Feb 21, 2025 at 2:10 PM Christian Thiel wrote: > +1 (non-binding) > > On Thu, 20 Feb 2025 at 19:47, Honah J. wrote: > >> +1 >> >> Best, >> Honah >> >> On Thu, Feb 20, 2025 at 10:45 AM Yufei Gu wrote: >

Re: [VOTE] Allow Row-Lineage with Equality Deletes

2025-02-21 Thread Christian Thiel
+1 (non-binding) On Thu, 20 Feb 2025 at 19:47, Honah J. wrote: > +1 > > Best, > Honah > > On Thu, Feb 20, 2025 at 10:45 AM Yufei Gu wrote: > >> +1 >> Yufei >> >> >> On Thu, Feb 20, 2025 at 10:12 AM rdb...@gmail.com >> wrote: >> >>> +1 >>> >>> On Thu, Feb 20, 2025 at 10:01 AM Aihua Xu wrote: >

Re: [VOTE] Allow Row-Lineage with Equality Deletes

2025-02-20 Thread Yufei Gu
+1 Yufei On Thu, Feb 20, 2025 at 10:12 AM rdb...@gmail.com wrote: > +1 > > On Thu, Feb 20, 2025 at 10:01 AM Aihua Xu wrote: > >> +1 (non-binding). >> >> On Thu, Feb 20, 2025 at 9:41 AM Huang-Hsiang Cheng >> wrote: >> >>> +1 (non-binding) >>> >>> Thanks, >>> Huang-Hsiang >>> >>> On Feb 20, 202

Re: [VOTE] Allow Row-Lineage with Equality Deletes

2025-02-20 Thread Honah J.
+1 Best, Honah On Thu, Feb 20, 2025 at 10:45 AM Yufei Gu wrote: > +1 > Yufei > > > On Thu, Feb 20, 2025 at 10:12 AM rdb...@gmail.com > wrote: > >> +1 >> >> On Thu, Feb 20, 2025 at 10:01 AM Aihua Xu wrote: >> >>> +1 (non-binding). >>> >>> On Thu, Feb 20, 2025 at 9:41 AM Huang-Hsiang Cheng >>>

Re: [VOTE] Allow Row-Lineage with Equality Deletes

2025-02-20 Thread rdb...@gmail.com
+1 On Thu, Feb 20, 2025 at 10:01 AM Aihua Xu wrote: > +1 (non-binding). > > On Thu, Feb 20, 2025 at 9:41 AM Huang-Hsiang Cheng > wrote: > >> +1 (non-binding) >> >> Thanks, >> Huang-Hsiang >> >> On Feb 20, 2025, at 9:37 AM, huaxin gao wrote: >> >> +1 (non-binding) >> >> Thanks Russell! >> >> On

Re: [VOTE] Allow Row-Lineage with Equality Deletes

2025-02-20 Thread Aihua Xu
+1 (non-binding). On Thu, Feb 20, 2025 at 9:41 AM Huang-Hsiang Cheng wrote: > +1 (non-binding) > > Thanks, > Huang-Hsiang > > On Feb 20, 2025, at 9:37 AM, huaxin gao wrote: > > +1 (non-binding) > > Thanks Russell! > > On Thu, Feb 20, 2025 at 1:57 AM Fokko Driesprong wrote: > >> +1 >> >> Thanks

Re: [VOTE] Allow Row-Lineage with Equality Deletes

2025-02-20 Thread Huang-Hsiang Cheng
+1 (non-binding) Thanks, Huang-Hsiang > On Feb 20, 2025, at 9:37 AM, huaxin gao wrote: > > +1 (non-binding) > > Thanks Russell! > > On Thu, Feb 20, 2025 at 1:57 AM Fokko Driesprong > wrote: >> +1 >> >> Thanks Russell! >> >> Op do 20 feb 2025 om 10:25 schreef Péter

Re: [VOTE] Allow Row-Lineage with Equality Deletes

2025-02-20 Thread huaxin gao
+1 (non-binding) Thanks Russell! On Thu, Feb 20, 2025 at 1:57 AM Fokko Driesprong wrote: > +1 > > Thanks Russell! > > Op do 20 feb 2025 om 10:25 schreef Péter Váry >: > >> +1 >> >> Manu Zhang ezt írta (időpont: 2025. febr. 20., >> Cs, 8:06): >> >>> +1 (non-binding) >>> >>> Regards >>> Manu >>

Re: [VOTE] Allow Row-Lineage with Equality Deletes

2025-02-20 Thread Fokko Driesprong
+1 Thanks Russell! Op do 20 feb 2025 om 10:25 schreef Péter Váry : > +1 > > Manu Zhang ezt írta (időpont: 2025. febr. 20., > Cs, 8:06): > >> +1 (non-binding) >> >> Regards >> Manu >> >> On Thu, Feb 20, 2025 at 2:57 PM Jean-Baptiste Onofré >> wrote: >> >>> +1 >>> >>> Regards >>> JB >>> >>> On W

Re: [VOTE] Allow Row-Lineage with Equality Deletes

2025-02-20 Thread Péter Váry
+1 Manu Zhang ezt írta (időpont: 2025. febr. 20., Cs, 8:06): > +1 (non-binding) > > Regards > Manu > > On Thu, Feb 20, 2025 at 2:57 PM Jean-Baptiste Onofré > wrote: > >> +1 >> >> Regards >> JB >> >> On Wed, Feb 19, 2025 at 11:13 PM Russell Spitzer >> wrote: >> > >> > The PR: https://github.com

Re: [VOTE] Allow Row-Lineage with Equality Deletes

2025-02-19 Thread Manu Zhang
+1 (non-binding) Regards Manu On Thu, Feb 20, 2025 at 2:57 PM Jean-Baptiste Onofré wrote: > +1 > > Regards > JB > > On Wed, Feb 19, 2025 at 11:13 PM Russell Spitzer > wrote: > > > > The PR: https://github.com/apache/iceberg/pull/12230 is basically > ready now. So let's do a last vote to make

Re: [VOTE] Allow Row-Lineage with Equality Deletes

2025-02-19 Thread Jean-Baptiste Onofré
+1 Regards JB On Wed, Feb 19, 2025 at 11:13 PM Russell Spitzer wrote: > > The PR: https://github.com/apache/iceberg/pull/12230 is basically ready now. > So let's do a last vote to make sure everyone is aware of the upcoming change. > > Before: > Equality deletes are not allowed to be used when

Re: [VOTE] Allow Row-Lineage with Equality Deletes

2025-02-19 Thread Prashant Singh
+1 (non-binding) Best, Prashant Singh On Wed, Feb 19, 2025 at 5:30 PM Gang Wu wrote: > +1 (non-binding) > > On Thu, Feb 20, 2025 at 7:12 AM Steven Wu wrote: > >> +1 >> >> On Wed, Feb 19, 2025 at 2:15 PM Russell Spitzer < >> russell.spit...@gmail.com> wrote: >> >>> The PR: https://github.com/ap

Re: [VOTE] Allow Row-Lineage with Equality Deletes

2025-02-19 Thread Gang Wu
+1 (non-binding) On Thu, Feb 20, 2025 at 7:12 AM Steven Wu wrote: > +1 > > On Wed, Feb 19, 2025 at 2:15 PM Russell Spitzer > wrote: > >> The PR: https://github.com/apache/iceberg/pull/12230 is basically ready >> now. So let's do a last vote to make sure everyone is aware of the upcoming >> cha

[VOTE] Allow Row-Lineage with Equality Deletes

2025-02-19 Thread Russell Spitzer
The PR: https://github.com/apache/iceberg/pull/12230 is basically ready now. So let's do a last vote to make sure everyone is aware of the upcoming change. Before: Equality deletes are not allowed to be used when row-lineage is enabled After: Equality deletes are allowed to be used when row-line

Re: [VOTE] Allow Row-Lineage with Equality Deletes

2025-02-19 Thread Steven Wu
+1 On Wed, Feb 19, 2025 at 2:15 PM Russell Spitzer wrote: > The PR: https://github.com/apache/iceberg/pull/12230 is basically ready > now. So let's do a last vote to make sure everyone is aware of the upcoming > change. > > Before: > Equality deletes are not allowed to be used when row-lineage