Re: [VOTE] Add commit timestamp to CommitReport

2025-05-21 Thread Manu Zhang
Thanks for your thoughts, JB. I agree with the concerns, but note that reading table metadata from the file system for each commit report is not cost-free. I'd rather use the system time instead of reading table metadata. Regards, Manu On Wed, May 21, 2025 at 3:56 PM Jean-Baptiste Onofré wrote:

Re: [VOTE] Add commit timestamp to CommitReport

2025-05-21 Thread Jean-Baptiste Onofré
+0 I don't see much value compared to reading the table metadata via snapshot id. I'm not against it, but it seems a bit redundant. Giving direct access via REST Catalog could be discussed also. Regards JB On Thu, May 8, 2025 at 5:01 PM Manu Zhang wrote: > > Hi all, > > I'd like to start a vote

Re: [VOTE] Add commit timestamp to CommitReport

2025-05-20 Thread Manu Zhang
Thanks Daniel for your thorough explanation. I understand your concern now and agree with this point. I feel like we're adding additional information that isn't accurate and > doesn't add a whole lot of value. > Actually, maintenance tasks scheduling doesn't require an accurate timestamp, which

Re: [VOTE] Add commit timestamp to CommitReport

2025-05-20 Thread Daniel Weeks
Hey Manu, I didn't see a discuss thread on this topic, so I'll add my concerns here. The issue I have is around the fidelity of what we're using as a commit timestamp. I feel like we're adding additional information that isn't accurate and doesn't add a whole lot of value. The metrics already in

Re: [VOTE] Add commit timestamp to CommitReport

2025-05-16 Thread Manu Zhang
Thanks Yufei. I'm still seeking more votes here. Manu On Wed, May 14, 2025 at 1:37 AM Yufei Gu wrote: > +1 I'm OK to add it as long as it's optional. > > Yufei > > > On Mon, May 12, 2025 at 8:47 PM Manu Zhang > wrote: > >> Hi all, >> >> The background is that we schedule maintenance jobs based

Re: [VOTE] Add commit timestamp to CommitReport

2025-05-13 Thread Yufei Gu
+1 I'm OK to add it as long as it's optional. Yufei On Mon, May 12, 2025 at 8:47 PM Manu Zhang wrote: > Hi all, > > The background is that we schedule maintenance jobs based on commit > reports for Iceberg tables, and we want to know *when commits happen*. > Adding timestamp to the commit repo

Re: [VOTE] Add commit timestamp to CommitReport

2025-05-12 Thread Manu Zhang
Hi all, The background is that we schedule maintenance jobs based on commit reports for Iceberg tables, and we want to know *when commits happen*. Adding timestamp to the commit report would save us from loading metadata of every table from the filesystem. Please take a look at the PR and cast yo

[VOTE] Add commit timestamp to CommitReport

2025-05-08 Thread Manu Zhang
Hi all, I'd like to start a vote to add commit timestamp `timestamp-millis` to CommitReport in PR 12990 . The timestamp info is valuable to schedule maintenance jobs, but currently we need to look it up from the snapshot metadata table. Please take a