Correct, we run check-license for each PR thanks to license_check.yml
GH workflow.
However, the contributor has to run the dev/check-license manually
(it's not part of gradle build).
I agree that the PR level is good enough. So, I propose to move
forward on a new rat version without dot-directory
We already run RAT checks on every PR, so I'm not sure there's a lot of
value in moving the checks to gradle. That just means that we would need to
use a different framework across the implementations. If there's a way to
run license checks in CI that doesn't have the dot-file limitation, that
seem
Thanks for the details!
To be honest, I still prefer the "light build" approach with gradle,
because it's pretty easy for contributors to check license headers in
their contributed file (as with gradle plugin, it will be included in
the check phase).
I think it's good to have it in the regular "lo
Here are some quick notes for skywalking-eyes, hoping them will be helpful.
Before using skywalking-eyes, we need to setup config as said in [1]. Take
iceberg-rust as an example [2].
For checking in CI:
Adding following content in workflow [3]
- name: Check License Header
uses: apache/skywal
Thanks for the heads up Xuanwo.
It's the fourth option :) I will make a comparison with RAT.
Regards
JB
On Fri, Oct 27, 2023 at 12:15 PM Xuanwo wrote:
>
> iceberg-rust is using apache/skywalking-eyes/header@v0.5.0 now.
>
> BTW, we found skywalking-eyes works really well. It's fast, correct and
iceberg-rust is using apache/skywalking-eyes/header@v0.5.0 now.
BTW, we found skywalking-eyes works really well. It's fast, correct and
well-maintained.
Maybe worth take a look.
On Fri, Oct 27, 2023, at 17:48, Jean-Baptiste Onofré wrote:
> By the way, as dev/check-license is also used in iceber
By the way, as dev/check-license is also used in iceberg-python and
iceberg-go repositories (iceberg-rust doesn't have it), maybe I can
move forward on new rat release with the fix on hidden directories and
update there as well.
Regards
JB
On Thu, Oct 26, 2023 at 5:19 PM Jean-Baptiste Onofré wro
Hi guys,
During the 1.4.1 vote, we identified some files without ASF headers,
more specifically in hidden directories (like .baseline). These files
have not been detected by dev/check-license script.
The reason is because the script uses apache-rat via java -jar (the
Apache RAT CLI), executing th
