Re: [Discuss] test logging is broken and Avro 1.12.0 upgraded slf4j-api dep to 2.x

2024-09-16 Thread Steven Wu
> Luckily, it doesn't look like we ship the SLF4J API in our runtime binaries, so we already have a situation where downstream projects can choose the SLF4J version of both the API and provider Jars. Ryan, this is a good point. Yes, our Spark and Flink runtime bundle jars exclude slf4j, which is a

Re: [Discuss] test logging is broken and Avro 1.12.0 upgraded slf4j-api dep to 2.x

2024-09-16 Thread Russell Spitzer
Sounds reasonable to me to just go to 2.x On Mon, Sep 16, 2024 at 1:10 PM rdb...@gmail.com wrote: > If I understand the SLF4J announcement correctly, it sounds like the best > option is to rely on binary compatibility between the 1.x and 2.x clients. > > As long as we don't use the newer API, th

Re: [Discuss] test logging is broken and Avro 1.12.0 upgraded slf4j-api dep to 2.x

2024-09-16 Thread rdb...@gmail.com
If I understand the SLF4J announcement correctly, it sounds like the best option is to rely on binary compatibility between the 1.x and 2.x clients. As long as we don't use the newer API, then the compiled code can use either a 1.7.x or 2.0.x API Jar. The API Jar needs to match the provider versio

Re: [Discuss] test logging is broken and Avro 1.12.0 upgraded slf4j-api dep to 2.x

2024-09-11 Thread Steven Wu
Following up on the discussion from the community sync meeting. Right now, Iceberg test code is in the 3rd row in the table pasted below. With the recent Avro 1.12 upgrade (and slf4j 2.x), the main code is also affected. That means downstream applications (Spark, Trino, Flink, ...) may run into the

Re: [Discuss] test logging is broken and Avro 1.12.0 upgraded slf4j-api dep to 2.x

2024-09-09 Thread Steven Wu
Bump the thread to bring the awareness of the issue and implication of slf4j 2.x upgrade. On Mon, Aug 26, 2024 at 12:24 PM Steve Zhang wrote: > I believe dependabot tried to upgrade self4j to 2.x in [1] but JB > mentioned there's -1 on this upgrade, maybe he has more context. > > [1]https://gith

Re: [Discuss] test logging is broken and Avro 1.12.0 upgraded slf4j-api dep to 2.x

2024-08-26 Thread Steve Zhang
I believe dependabot tried to upgrade self4j to 2.x in [1] but JB mentioned there's -1 on this upgrade, maybe he has more context. [1]https://github.com/apache/iceberg/pull/9688 Thanks, Steve Zhang > On Aug 24, 2024, at 7:37 PM, Steven Wu wrote: > > Hi, > > It seems that test logging is br

[Discuss] test logging is broken and Avro 1.12.0 upgraded slf4j-api dep to 2.x

2024-08-24 Thread Steven Wu
Hi, It seems that test logging is broken in many modules (like core, flink) because slf4j-api was upgraded to 2.x while slf4j-simple provider is still on 1.7. I created a PR that upgraded slf4j-simple testImplementation to 2.x for all subprojects. https://github.com/apache/iceberg/pull/11001 Tha