Re: [Discuss] Make identity(String sourceName, String targetName) Public

2025-05-29 Thread Ryan Blue
Sorry, I didn't come back to this after I initially read it. I think it's fine to make this change because we can definitely have identity transform partition fields that don't match after a rename. If I remember correctly, the reason for not making this public was just to ensure partition field na

Re: [Discuss] Make identity(String sourceName, String targetName) Public

2025-05-29 Thread Russell Spitzer
I'm not seeing any strong feelings on this so I'm going to go ahead and merge. If anyone else sees issues we can always address this in a follow up. On Wed, May 21, 2025 at 6:07 PM Steven Wu wrote: > It seems that the PR has made two valid arguments to support to change of > public scope > * ide

Re: [Discuss] Make identity(String sourceName, String targetName) Public

2025-05-21 Thread Steven Wu
It seems that the PR has made two valid arguments to support to change of public scope * identity transform builder is the only one where targetName builder is not public * handle the partition column rename use case So it seems reasonable to me. On Wed, May 21, 2025 at 2:49 PM Russell Spitzer

[Discuss] Make identity(String sourceName, String targetName) Public

2025-05-21 Thread Russell Spitzer
Hi Y'all We've been considering making a change to the Identity Partition Transform builder. Unlikely all of the other builders, Identity doesn't allow you to make an Identity Transform with a name different from the column you are transforming. We want to be able to construct in memory a TableMe