Re: [DISCUSS] Standardizing Error Handling in the Iceberg Spark Module

2024-12-19 Thread Jean-Baptiste Onofré
It sounds good, +1. Thanks ! Regards JB Le jeu. 19 déc. 2024 à 08:36, huaxin gao a écrit : > Hi everyone, > > While working on integrating Spark 4.0 with Iceberg, I noticed that error > conditions in the Spark module are primarily validated through the content > of error messages. I need to rev

Re: [DISCUSS] Standardizing Error Handling in the Iceberg Spark Module

2024-12-19 Thread roryqi
Great work! Rodrigo Meneses 于2024年12月20日周五 10:38写道: > Thanks a lots it’s a great improvement. I’ll check what’s the current > behavior that we have on flink with respect to error handling ! > > On Thu, Dec 19, 2024 at 3:46 PM Anurag Mantripragada > wrote: > >> This is great. +1 from me. Thanks

Re: [DISCUSS] Standardizing Error Handling in the Iceberg Spark Module

2024-12-19 Thread Rodrigo Meneses
Thanks a lots it’s a great improvement. I’ll check what’s the current behavior that we have on flink with respect to error handling ! On Thu, Dec 19, 2024 at 3:46 PM Anurag Mantripragada wrote: > This is great. +1 from me. Thanks Huaxin. > > > Anurag Mantripragada > > > > > > > On Dec 19, 2024,

Re: [DISCUSS] Standardizing Error Handling in the Iceberg Spark Module

2024-12-19 Thread Anurag Mantripragada
This is great. +1 from me. Thanks Huaxin. Anurag Mantripragada > On Dec 19, 2024, at 12:39 PM, Prashant Singh wrote: > > +1, Thanks, Huaxin ! > > On Thu, Dec 19, 2024 at 10:41 AM John Zhuge > wrote: >> +1 Thanks >> >> John Zhuge >> >> >> On Thu, Dec 19, 2024

Re: [DISCUSS] Standardizing Error Handling in the Iceberg Spark Module

2024-12-19 Thread Prashant Singh
+1, Thanks, Huaxin ! On Thu, Dec 19, 2024 at 10:41 AM John Zhuge wrote: > +1 Thanks > > John Zhuge > > > On Thu, Dec 19, 2024 at 9:47 AM Yufei Gu wrote: > >> +1 on the direction. It's great that Spark has standardized the error >> code so that Iceberg didn't have to rely on error messages. >> >

Re: [DISCUSS] Standardizing Error Handling in the Iceberg Spark Module

2024-12-19 Thread John Zhuge
+1 Thanks John Zhuge On Thu, Dec 19, 2024 at 9:47 AM Yufei Gu wrote: > +1 on the direction. It's great that Spark has standardized the error code > so that Iceberg didn't have to rely on error messages. > > Yufei > > > On Thu, Dec 19, 2024 at 8:47 AM rdb...@gmail.com wrote: > >> This looks li

Re: [DISCUSS] Standardizing Error Handling in the Iceberg Spark Module

2024-12-19 Thread Yufei Gu
+1 on the direction. It's great that Spark has standardized the error code so that Iceberg didn't have to rely on error messages. Yufei On Thu, Dec 19, 2024 at 8:47 AM rdb...@gmail.com wrote: > This looks like a good improvement to me. Thanks, Huaxin! > > On Wed, Dec 18, 2024 at 11:37 PM huaxi

Re: [DISCUSS] Standardizing Error Handling in the Iceberg Spark Module

2024-12-19 Thread rdb...@gmail.com
This looks like a good improvement to me. Thanks, Huaxin! On Wed, Dec 18, 2024 at 11:37 PM huaxin gao wrote: > Hi everyone, > > While working on integrating Spark 4.0 with Iceberg, I noticed that error > conditions in the Spark module are primarily validated through the content > of error messag

[DISCUSS] Standardizing Error Handling in the Iceberg Spark Module

2024-12-18 Thread huaxin gao
Hi everyone, While working on integrating Spark 4.0 with Iceberg, I noticed that error conditions in the Spark module are primarily validated through the content of error messages. I need to revise some of the validation because the error messages have changed in Spark 4.0. Spark has standardized