Re: [DISCUSS] Change Behavior for SchemaUpdate.UnionByName

2024-11-01 Thread Rocco Varela
> I think removing states in which the API would fail is good and although >> we didn't document it exactly this way before, I'm having a hard time >> thinking of a case in which throwing an exception here would have been >> preferable to a noop? Does anyone else have strong

[DISCUSS] Change Behavior for SchemaUpdate.UnionByName

2024-10-31 Thread Rocco Varela
Hi everyone, Apologize if this is landing twice, my first attempt got lost somewhere in transit :) I have a PR that attempts to address https://github.com/apache/iceberg/issues/4849, basically adding logic to ignore downcasting column types when "mergeSchema" is set when an existing column type i