Re: [VOTE] Release Apache Iceberg Rust 0.5.0 RC1

2025-05-21 Thread Xuanwo
> I also saw that the script hardcoded a few "cargo directories" and only ran > commands against those directories. Is this correct? There are other > directories with `Cargo.toml` files. For example, running `find . -name > Cargo.toml -exec dirname {} \;`, I found these other subdirectories eac

Re: [VOTE] Release Apache Iceberg 1.9.1 RC0

2025-05-21 Thread Jean-Baptiste Onofré
Hi Aihua Ok got it. Thanks. Yes I agree with you: it has to be fixed as it sounds like a regression not seen on 1.9.0. Regards JB Le jeu. 22 mai 2025 à 02:00, Aihua Xu a écrit : > JB, this is actually not a full revert but just a small change to make the > client with 1.9.x library to work wit

Re: [VOTE] Release Apache Iceberg 1.9.1 RC1

2025-05-21 Thread Ajantha Bhat
Thanks Ebihara for pointing me to the change. We should probably capture end user related changes in the release notes (separate section). I will close that issue. I am good with this RC. I will test and vote. On Thu, May 22, 2025 at 10:26 AM Yuya Ebihara < yuya.ebih...@starburstdata.com> wrote:

Re: [VOTE] Release Apache Iceberg 1.9.1 RC1

2025-05-21 Thread Yuya Ebihara
Hi Ajantha, https://github.com/apache/iceberg/pull/12318 made JSON un-pretty for reduing the file size. BR, Yuya On Thu, May 22, 2025 at 1:52 PM Ajantha Bhat wrote: > Hi Russell, > > Just observed this change (table metadata JSON file is not formatted > anymore) > https://github.com/apache/ice

Re: [VOTE] Release Apache Iceberg 1.9.1 RC1

2025-05-21 Thread Ajantha Bhat
Hi Russell, Just observed this change (table metadata JSON file is not formatted anymore) https://github.com/apache/iceberg/issues/13122 If it is induced by 1.9.0, we should probably fix it and include it in RC? No functional impact. - Ajantha On Thu, May 22, 2025 at 4:49 AM Russell Spitzer wr

Re: [VOTE] Release Apache Iceberg Rust 0.5.0 RC1

2025-05-21 Thread Justin Mclean
Hi, Note that MPL-2.0 is considered category B [1] and is fine to have as a dependency; it just can’t be included in a source release. Kind Regards, Justin 1. https://www.apache.org/legal/resolved.html#category-b > On 22 May 2025, at 7:43 AM, Fokko Driesprong wrote: > > Hey everyone, > > I

Re: [VOTE] Release Apache Iceberg Rust 0.5.0 RC1

2025-05-21 Thread Kevin Liu
Thank you for catching this, Fokko! Turns out I skipped the step to install `cargo-deny` when generating the `DEPENDENCIES.rust.tsv` files. The generation script ran `cargo deny` unsuccesfully but did not error. I've added https://github.com/apache/iceberg-rust/pull/1366 to make the script more re

Re: [VOTE] Release Apache Iceberg 1.9.1 RC0

2025-05-21 Thread Russell Spitzer
Fix is merged and in rc1 On Wed, May 21, 2025 at 8:00 PM Aihua Xu wrote: > JB, this is actually not a full revert but just a small change to make the > client with 1.9.x library to work with the existing catalog server. The > server will upgrade to 1.9.x and then the client will upgrade in the >

Re: [VOTE] Release Apache Iceberg Rust 0.5.0 RC1

2025-05-21 Thread Renjie Liu
Thanks Fokko for this fix, I've merged this pr. Hi, Kevin: Would you help to create another rc? On Thu, May 22, 2025 at 5:44 AM Fokko Driesprong wrote: > Hey everyone, > > I wanted to check the licenses, so I ran the scripts to generate them > since the DEPENDENCIES.rust.tsv files in the repo

Re: [VOTE] Release Apache Iceberg 1.9.1 RC0

2025-05-21 Thread Aihua Xu
JB, this is actually not a full revert but just a small change to make the client with 1.9.x library to work with the existing catalog server. The server will upgrade to 1.9.x and then the client will upgrade in the following release. I feel it's a regression which didn't catch in 1.9.0 and make se

Re: Spark 4.0/Iceberg Integration Merged – Spark 3.5 Merges Can Resume

2025-05-21 Thread Manish Malhotra
Thanks Huaxin, for taking this to completion! On Mon, May 19, 2025 at 12:05 PM Aihua Xu wrote: > Thanks a lot to get that merged! Huaxin. > > On Fri, May 16, 2025 at 12:05 PM Amogh Jahagirdar <2am...@gmail.com> > wrote: > >> Thanks Huaxin for your patience while getting this through! >> >> On Fr

[VOTE] Release Apache Iceberg 1.9.1 RC1

2025-05-21 Thread Russell Spitzer
Hi Y'all, I propose that we release the following RC as the official Apache Iceberg 1.9.1 release. The commit ID is f40208ae6fb2f33e578c2637d3dea1db18739f31 * This corresponds to the tag: apache-iceberg-1.9.1-rc1 * https://github.com/apache/iceberg/commits/apache-iceberg-1.9.1-rc1 * https://githu

Re: [Discuss] Make identity(String sourceName, String targetName) Public

2025-05-21 Thread Steven Wu
It seems that the PR has made two valid arguments to support to change of public scope * identity transform builder is the only one where targetName builder is not public * handle the partition column rename use case So it seems reasonable to me. On Wed, May 21, 2025 at 2:49 PM Russell Spitzer

Re: [VOTE][Go] Release Apache Iceberg Go v0.3.0 RC0

2025-05-21 Thread Leon Lin
+1 (non-binding) Thank you Matt for running the release! On Wed, May 21, 2025 at 10:32 AM Kevin Liu wrote: > +1 (non-binding) > > [x] Download links are valid. > [x] Checksums and signatures. > [x] LICENSE/NOTICE files exist > [x] No unexpected binary files > [x] All source files have ASF heade

Re: [VOTE] Release Apache Iceberg 1.9.1 RC0

2025-05-21 Thread Russell Spitzer
Closing this vote to get in the fix requested by Aihua. New RC incoming! On Wed, May 21, 2025 at 2:59 AM Jean-Baptiste Onofré wrote: > As it's not a "regression" (it was like this in 1.9.0 even if not > "seen"), I'm fine to continue with the 1.9.1 release. We probably need > to work on a better/

[Discuss] Make identity(String sourceName, String targetName) Public

2025-05-21 Thread Russell Spitzer
Hi Y'all We've been considering making a change to the Identity Partition Transform builder. Unlikely all of the other builders, Identity doesn't allow you to make an Identity Transform with a name different from the column you are transforming. We want to be able to construct in memory a TableMe

Re: [VOTE] Release Apache Iceberg Rust 0.5.0 RC1

2025-05-21 Thread Fokko Driesprong
Hey everyone, I wanted to check the licenses, so I ran the scripts to generate them since the DEPENDENCIES.rust.tsv files in the repo are empty (an example here ). It also includes category B licenses: *➜ **ic

Re: [VOTE] Release Apache Iceberg Rust 0.5.0 RC1

2025-05-21 Thread Christian Thiel
Thanks Kevin! +1 non-binding Checklist for reference: [x] Download links are valid. [x] Checksums and signatures. [x] LICENSE/NOTICE files exist [x] No unexpected binary files [x] All source files have ASF headers [x] Can compile from source [x] Doesn't break pipelines badly which are very dear to

Re: [VOTE][Go] Release Apache Iceberg Go v0.3.0 RC0

2025-05-21 Thread Kevin Liu
+1 (non-binding) [x] Download links are valid. [x] Checksums and signatures. [x] LICENSE/NOTICE files exist [x] No unexpected binary files [x] All source files have ASF headers [x] Can compile from source Ran verification script, `./dev/release/verify_rc.sh 0.3.0 0` Compiled the CLI and ran a fe

Re: Should DDL operations always create new snapshots?

2025-05-21 Thread Brian Hulette
I think I'm -0 for a side-channel approach like this. It solves this immediate problem, but it feels like a band-aid. Coming back to Ryan's initial response: > If you want to create new snapshots when the schema changes it is alright to do it, but I don’t think that we need to require it in the sp

Re: Discuss proposal - IRC APIs for Multi-Statement Multi-Table Transactions

2025-05-21 Thread Maninderjit Singh
Hi dev community, Following up on the thread here to continue the discussion and get feedback since we couldn't get to it in sync. I think we have made some progress in the discussion that I want to capture while highlighting the items where we need to create consensus along with pros and cons. I w

Re: [VOTE] Adopt the v3 spec changes

2025-05-21 Thread Brian Hulette
+1 (non-binding) On Wed, May 21, 2025 at 12:56 AM Jean-Baptiste Onofré wrote: > +1 (non binding) > > Regards > JB > > On Mon, May 19, 2025 at 11:20 PM Ryan Blue wrote: > > > > Hi everyone, > > > > With the follow-ups from the earlier discussion thread wrapped up, I’d > like to raise a vote to a

Re: [VOTE] Release Apache Iceberg Rust 0.5.0 RC1

2025-05-21 Thread Zheng Hu
Thank Kevin for the work, Here is my result. +1 binding. Checklist for reference: [x] Download links are valid. [x] Checksums and signatures. [x] LICENSE/NOTICE files exist [x] No unexpected binary files [x] All source files have ASF headers [x] Can compile from source On Wed, May 21, 2025 at 8:

Re: [VOTE] Release Apache Iceberg Rust 0.5.0 RC1

2025-05-21 Thread NOTME ZE
Thank you Kevin for working on this! +1 non-binding - [x] Download links are valid. - [x] Checksums and signatures. - [x] LICENSE/NOTICE files exist - [x] No unexpected binary files - [x] All source files have ASF headers - [x] Can compile from source Xuanwo 于2025年5月21日周三 10:59写道: > Thank you

[VOTE][Go] Release Apache Iceberg Go v0.3.0 RC0

2025-05-21 Thread Matt Topol
Hi, I would like to propose the following release candidate (RC0) of Apache Iceberg Go version v0.3.0. This release candidate is based on commit: 8270498f1932bececb5cec22c174df5f1865f7eb [1] The source release rc0 is hosted at [2]. Please download, verify checksums and signatures, run the unit

[DISCUSS] Dynamic Schema / Partition Spec Changes

2025-05-21 Thread Maximilian Michels
Hi folks, Imagine a data processing job, which reads from a data source and outputs to Iceberg tables. The catch is that table name, schema / spec, branch, etc. are only available at runtime in the data itself. Many users have worked around this by writing the data to a temporary destination, then

Re: Core changes for Flink Dynamic Iceberg Sink

2025-05-21 Thread Maximilian Michels
Thanks Ryan! I totally missed those static method constructors (maybe because they are in an entirely different class). In that case, we don't need change (1) and (2). For SchemaUpdate, I agree we could implement the interface. The drawback is that it won't verify test results with the actual impl

Re: [VOTE] Add commit timestamp to CommitReport

2025-05-21 Thread Manu Zhang
Thanks for your thoughts, JB. I agree with the concerns, but note that reading table metadata from the file system for each commit report is not cost-free. I'd rather use the system time instead of reading table metadata. Regards, Manu On Wed, May 21, 2025 at 3:56 PM Jean-Baptiste Onofré wrote:

Re: [VOTE] Release Apache Iceberg 1.9.1 RC0

2025-05-21 Thread Jean-Baptiste Onofré
As it's not a "regression" (it was like this in 1.9.0 even if not "seen"), I'm fine to continue with the 1.9.1 release. We probably need to work on a better/complete fix. I'm not sure reverting this change would make sense either. I'm more in favor of continuing the 1.9.1 vote. Regards JB On Mon

Re: [VOTE] Add commit timestamp to CommitReport

2025-05-21 Thread Jean-Baptiste Onofré
+0 I don't see much value compared to reading the table metadata via snapshot id. I'm not against it, but it seems a bit redundant. Giving direct access via REST Catalog could be discussed also. Regards JB On Thu, May 8, 2025 at 5:01 PM Manu Zhang wrote: > > Hi all, > > I'd like to start a vote

Re: [VOTE] Adopt the v3 spec changes

2025-05-21 Thread Jean-Baptiste Onofré
+1 (non binding) Regards JB On Mon, May 19, 2025 at 11:20 PM Ryan Blue wrote: > > Hi everyone, > > With the follow-ups from the earlier discussion thread wrapped up, I’d like > to raise a vote to adopt the v3 spec changes. > > What is included? > > Default values for columns and fields > New ty