Re: [VOTE] Adopt the v3 spec changes

2025-05-19 Thread Fokko Driesprong
+1 (binding) Huge milestone, thanks for driving this, Ryan! Kind regards, Fokko Op di 20 mei 2025 om 08:45 schreef huaxin gao : > +1 (non-binding) > > On Mon, May 19, 2025 at 11:17 PM Eduard Tudenhöfner < > etudenhoef...@apache.org> wrote: > >> +1 (binding) >> >> On Tue, May 20, 2025 at 8:14 AM

Re: [VOTE] Adopt the v3 spec changes

2025-05-19 Thread huaxin gao
+1 (non-binding) On Mon, May 19, 2025 at 11:17 PM Eduard Tudenhöfner < etudenhoef...@apache.org> wrote: > +1 (binding) > > On Tue, May 20, 2025 at 8:14 AM Gidon Gershinsky wrote: > >> +1 (non-binding). >> Glad to see this big step forward. >> >> Cheers, Gidon >> >> >> On Tue, May 20, 2025 at 9:0

Re: [VOTE] Adopt the v3 spec changes

2025-05-19 Thread Eduard Tudenhöfner
+1 (binding) On Tue, May 20, 2025 at 8:14 AM Gidon Gershinsky wrote: > +1 (non-binding). > Glad to see this big step forward. > > Cheers, Gidon > > > On Tue, May 20, 2025 at 9:00 AM Ajantha Bhat > wrote: > >> +1 (non-binding) >> >> Excited to see Iceberg V3 coming together! >> >> - Ajantha >> >

Re: [VOTE] Adopt the v3 spec changes

2025-05-19 Thread Gidon Gershinsky
+1 (non-binding). Glad to see this big step forward. Cheers, Gidon On Tue, May 20, 2025 at 9:00 AM Ajantha Bhat wrote: > +1 (non-binding) > > Excited to see Iceberg V3 coming together! > > - Ajantha > > On Tue, May 20, 2025 at 11:22 AM Christian Thiel < > christian.t.b...@gmail.com> wrote: > >

Re: [VOTE] Adopt the v3 spec changes

2025-05-19 Thread Ajantha Bhat
+1 (non-binding) Excited to see Iceberg V3 coming together! - Ajantha On Tue, May 20, 2025 at 11:22 AM Christian Thiel wrote: > +1 (non-binding) > > Christian > > Prashant Singh schrieb am Di. 20. Mai 2025 um > 07:34: > >> +1 (non-binding) >> >> Best, >> Prashant >> >> On Mon, May 19, 2025 at

Re: [VOTE] Adopt the v3 spec changes

2025-05-19 Thread Christian Thiel
+1 (non-binding) Christian Prashant Singh schrieb am Di. 20. Mai 2025 um 07:34: > +1 (non-binding) > > Best, > Prashant > > On Mon, May 19, 2025 at 10:19 PM Aihua Xu wrote: > >> +1 (non-binding). Great to see we are moving forward. >> >> On Mon, May 19, 2025 at 9:06 PM Denny Lee wrote: >> >>

Re: [VOTE] Adopt the v3 spec changes

2025-05-19 Thread Aihua Xu
+1 (non-binding). Great to see we are moving forward. On Mon, May 19, 2025 at 9:06 PM Denny Lee wrote: > +1 (non-binding) > > On Mon, May 19, 2025 at 9:04 PM Yufei Gu wrote: > >> +1 (binding) >> >> Yufei >> >> >> On Mon, May 19, 2025 at 8:59 PM Amogh Jahagirdar <2am...@gmail.com> >> wrote: >>

Re: [VOTE] Adopt the v3 spec changes

2025-05-19 Thread Prashant Singh
+1 (non-binding) Best, Prashant On Mon, May 19, 2025 at 10:19 PM Aihua Xu wrote: > +1 (non-binding). Great to see we are moving forward. > > On Mon, May 19, 2025 at 9:06 PM Denny Lee wrote: > >> +1 (non-binding) >> >> On Mon, May 19, 2025 at 9:04 PM Yufei Gu wrote: >> >>> +1 (binding) >>> >>

Re: [VOTE] Adopt the v3 spec changes

2025-05-19 Thread Denny Lee
+1 (non-binding) On Mon, May 19, 2025 at 9:04 PM Yufei Gu wrote: > +1 (binding) > > Yufei > > > On Mon, May 19, 2025 at 8:59 PM Amogh Jahagirdar <2am...@gmail.com> wrote: > >> +1 (binding) >> >> On Mon, May 19, 2025 at 9:37 PM Gang Wu wrote: >> >>> +1 (non-binding) >>> >>> On Tue, May 20, 2025

Re: [VOTE] Adopt the v3 spec changes

2025-05-19 Thread Yufei Gu
+1 (binding) Yufei On Mon, May 19, 2025 at 8:59 PM Amogh Jahagirdar <2am...@gmail.com> wrote: > +1 (binding) > > On Mon, May 19, 2025 at 9:37 PM Gang Wu wrote: > >> +1 (non-binding) >> >> On Tue, May 20, 2025 at 11:35 AM Manish Malhotra < >> manish.malhotra.w...@gmail.com> wrote: >> >>> +1 (no

Re: [VOTE] Adopt the v3 spec changes

2025-05-19 Thread Amogh Jahagirdar
+1 (binding) On Mon, May 19, 2025 at 9:37 PM Gang Wu wrote: > +1 (non-binding) > > On Tue, May 20, 2025 at 11:35 AM Manish Malhotra < > manish.malhotra.w...@gmail.com> wrote: > >> +1 (non-binding) >> >> This is Awesome! Thanks 🙏🏼 >> >> On Mon, May 19, 2025 at 6:09 PM Szehon Ho >> wrote: >> >>>

Re: [VOTE] Adopt the v3 spec changes

2025-05-19 Thread Gang Wu
+1 (non-binding) On Tue, May 20, 2025 at 11:35 AM Manish Malhotra < manish.malhotra.w...@gmail.com> wrote: > +1 (non-binding) > > This is Awesome! Thanks 🙏🏼 > > On Mon, May 19, 2025 at 6:09 PM Szehon Ho wrote: > >> +1 (binding) >> >> Thanks, it's an exciting step for Iceberg! >> Szehon >> >> On

Re: [VOTE] Adopt the v3 spec changes

2025-05-19 Thread Manish Malhotra
+1 (non-binding) This is Awesome! Thanks 🙏🏼 On Mon, May 19, 2025 at 6:09 PM Szehon Ho wrote: > +1 (binding) > > Thanks, it's an exciting step for Iceberg! > Szehon > > On Mon, May 19, 2025 at 4:03 PM Jia Yu wrote: > >> This is exciting! >> >> +1 (non-binding) >> >> On Mon, May 19, 2025 at 3:27

Re: [VOTE] Adopt the v3 spec changes

2025-05-19 Thread Szehon Ho
+1 (binding) Thanks, it's an exciting step for Iceberg! Szehon On Mon, May 19, 2025 at 4:03 PM Jia Yu wrote: > This is exciting! > > +1 (non-binding) > > On Mon, May 19, 2025 at 3:27 PM Ryan Blue wrote: > >> +1 (binding) >> >> I’ve gone through the changes in detail and I’m confident that they

Re: [VOTE] Adopt the v3 spec changes

2025-05-19 Thread Jia Yu
This is exciting! +1 (non-binding) On Mon, May 19, 2025 at 3:27 PM Ryan Blue wrote: > +1 (binding) > > I’ve gone through the changes in detail and I’m confident that they are > implementable and working. > >- Reviewed and updated row lineage core implementation, >readers/writers, and up

Re: [VOTE] Adopt the v3 spec changes

2025-05-19 Thread Ryan Blue
+1 (binding) I’ve gone through the changes in detail and I’m confident that they are implementable and working. - Reviewed and updated row lineage core implementation, readers/writers, and updates to Spark 3.5 - Validated the Variant encoding and shredding spec - Built readers/writers

[VOTE] Adopt the v3 spec changes

2025-05-19 Thread Ryan Blue
Hi everyone, With the follow-ups from the earlier discussion thread wrapped up, I’d like to raise a vote to adopt the v3 spec changes . *What is included?* - Default values for columns and f

Re: [VOTE] Release Apache Iceberg 1.9.1 RC0

2025-05-19 Thread Aihua Xu
I think it makes sense to do a "partial revert" so the core for the client will produce a single snapshot that the existing server understands. We can upgrade the client in 1.10 to produce bulk snapshots. Please help check out the PR . Thanks, Aihua O

Re: Spark 4.0/Iceberg Integration Merged – Spark 3.5 Merges Can Resume

2025-05-19 Thread Aihua Xu
Thanks a lot to get that merged! Huaxin. On Fri, May 16, 2025 at 12:05 PM Amogh Jahagirdar <2am...@gmail.com> wrote: > Thanks Huaxin for your patience while getting this through! > > On Fri, May 16, 2025 at 12:20 PM Steve wrote: > >> Thanks Huaxin! Great work and looking forward to the spark 4.0

Re: [VOTE] Release Apache Iceberg 1.9.1 RC0

2025-05-19 Thread Amogh Jahagirdar
I'm +0 on a full revert in 1.9 since this really just has to do with client/server implementation behavior guarantees. What I think Ryan was suggesting was that if we could first enable the ability for servers to handle multiple snapshots and then on a subsequent release, clients could then produce

Re: [VOTE] Release Apache Iceberg 1.9.1 RC0

2025-05-19 Thread Aihua Xu
Yeah. It's a change in 1.9.0 that was not caught in release. Seems revert is pretty straightforward and I just submitted the PR if we are OK to revert in 1.9.1. On Mon, May 19, 2025 at 10:26 AM Russell Spitzer wrote: > As a heads up, this change >

Re: [VOTE] Release Apache Iceberg 1.9.1 RC0

2025-05-19 Thread Russell Spitzer
As a heads up, this change is already present in 1.9.0. We could hold off on 1.9.1 until we have a change that reverts the behavior in 1.9.0. I think that would be fine as long as we have a volunteer to work on it,

Re: [VOTE] Release Apache Iceberg 1.9.1 RC0

2025-05-19 Thread Ryan Blue
I think we should address the problem that Aihua pointed out. Even if we can technically say that we are following the spec, this is a behavior change that is known to break with existing REST catalog services. I don't think that we should release a version that is known to break with existing serv

Re: [VOTE] Release Apache Iceberg 1.9.1 RC0

2025-05-19 Thread Amogh Jahagirdar
Thanks Aihua and Ajantha who pointed this out, If I understand the issue correctly, I don't think I consider it as an incompatible change. The REST protocol always allowed for clients to remove snapshots in bulk

Re: Hive 4 support

2025-05-19 Thread Wing Yew Poon
Peter and Denys, thank you for your responses. First, I'd like to get agreement on producing separate iceberg-hive-metastore jars for Hive 2, 3 and 4. Peter, do you agree with that? Second, if we do that, I listed three options for the runtime jars of engines, and it appears that you prefer option

Core changes for Flink Dynamic Iceberg Sink

2025-05-19 Thread Maximilian Michels
Hi, The Flink Dynamic Iceberg Sink requires a few iceberg-core class visibility changes, which I'd like to get your feedback on. Here is the diff: https://github.com/apache/iceberg/pull/13032/commits/1804b0ac4ff97c3c943463725e91a1e24b0f8c44 There are three visibility changes: Change 1: Make Nam

Re: Hive 4 support

2025-05-19 Thread Péter Váry
Thanks for working on this @Wing Yew Poon ! As I have mentioned on the PR, I would prefer unbundling the hive-metastore dependency from the runtime jars. This would help in multiple ways: - Decrease the size of the runtime jars - nowadays more-and-more people use Iceberg against a REST catalog, so

Re: [VOTE] Release Apache Iceberg 1.9.1 RC0

2025-05-19 Thread Aihua Xu
I have verified RC against Snowflake build. Everything works except one issue introduced by https://github.com/apache/iceberg/pull/12670/ : the client with 1.9.x can't work with the catalog server with old library to remove the snapshots since the the client now will remove the snapshots in bulk w

Re: Hive 4 support

2025-05-19 Thread Denys Kuzmenko
Hi Wing Yew, Hive-2.x and Hive 3.x are EOL. We encourage everyone to upgrade instead of keeping compatibility with the legacy versions. Note: Spark started migration to Hive-4.0, and we are helping here: https://github.com/apache/spark/pull/50213 Regards, Denys

Re: [VOTE] Release Apache Iceberg 1.9.1 RC0

2025-05-19 Thread Péter Váry
+1 (binding) Verified signature, built, and run some tests Maximilian Michels ezt írta (időpont: 2025. máj. 19., H, 11:17): > +1 (non-binding) > > 1. Verified the archive checksum and signature > 2. Extracted and inspected the source code for binaries > 3. Compiled and tested the source code > 4

Re: [VOTE] Release Apache Iceberg 1.9.1 RC0

2025-05-19 Thread Maximilian Michels
+1 (non-binding) 1. Verified the archive checksum and signature 2. Extracted and inspected the source code for binaries 3. Compiled and tested the source code 4. Verified license files / headers -Max On Mon, May 19, 2025 at 6:52 AM Daniel Weeks wrote: > > +1 (binding) > > Verified sigs/sums/lic