Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-27 Thread Eduard Tudenhöfner
Thanks everyone for participating. The vote result is: +1: 6 (binding), 8 (non-binding) +0: 0 -1: 0 Therefore, the release candidate is passed. On Thu, Feb 27, 2025 at 10:53 PM Steve Zhang wrote: > +1 (non-binding) > > - Checked signature/SHA512 > - Ran RAT license check > - Ran tests on JDK1

Re: Clarification on sorting floating-point numbers

2025-02-27 Thread Gang Wu
FYI: there was an effort from Jan (cc'd) to introduce a total order for floating-point numbers on the Parquet side: [1][2]. [1] https://github.com/apache/parquet-format/pull/221 [2] https://github.com/apache/parquet-format/pull/196 On Thu, Feb 27, 2025 at 4:24 AM Devin Smith wrote: > The spec h

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-27 Thread Aihua Xu
Thanks Alex. On Thu, Feb 27, 2025 at 10:31 AM Alex Dutra wrote: > Hi Aihua, > > I was indeed suspecting that you had a custom RESTClient :-) Thanks for > digging further and clarifying! Let me know if you need my help in adapting > your code. > > And with that: +1 (non-binding) from me as well.

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-27 Thread Steve Zhang
+1 (non-binding) - Checked signature/SHA512 - Ran RAT license check - Ran tests on JDK17 Thanks, Steve Zhang > On Feb 27, 2025, at 11:45 AM, Daniel Weeks wrote: > > +1 (binding) > > Verified sigs/sums/license/build/test (Java 17) > > -Dan > > On Thu, Feb 27, 2025 at 11:30 AM Aihua Xu

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-27 Thread Daniel Weeks
+1 (binding) Verified sigs/sums/license/build/test (Java 17) -Dan On Thu, Feb 27, 2025 at 11:30 AM Aihua Xu wrote: > Thanks Alex. > > On Thu, Feb 27, 2025 at 10:31 AM Alex Dutra > wrote: > >> Hi Aihua, >> >> I was indeed suspecting that you had a custom RESTClient :-) Thanks for >> digging fu

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-27 Thread Alex Dutra
Hi Aihua, I was indeed suspecting that you had a custom RESTClient :-) Thanks for digging further and clarifying! Let me know if you need my help in adapting your code. And with that: +1 (non-binding) from me as well. Thanks, Alex On Thu, Feb 27, 2025 at 6:45 PM Aihua Xu wrote: > Hi Alex, >

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-27 Thread Aihua Xu
Hi Alex, I checked our code further. We have an internal implementation for RESTClient which needs an update after your change to place the token in DefaultAuthSession and not pass through initHeaders anymore. The existing code assumes the token coming from initHeaders and we need to make the chan

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-27 Thread Alex Dutra
Hi Aihua Xu, I reviewed your PR but without further details I do not agree with your change, and I am unable to reproduce the issue. Besides, we have unit tests that cover this extensively. Could you please provide a simple reproducer or a test case? Thanks! Alex On Thu, Feb 27, 2025 at 5:06 P

Re: [DISCUSS][Rust] Frequency of upgrading minimum supported rust version.

2025-02-27 Thread xxchan
Conclusion in today's meeting: - Test against latest version in CI (by updating Cargo.lock with dependabot) - Have a wider range of versions support, to allow users to choose their dep version (by not updating Cargo.toml too often). Perhaps need to add a CI to test against oldest version. On Thu,

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-27 Thread Aihua Xu
I'm running within our integration tests. I'm able to trace and find the breaking change: https://github.com/apache/iceberg/pull/11992. Seems we need to make the following changes to pass the token: https://github.com/apache/iceberg/pull/12415/files. Alex, can you help take a look at this? if (ha

Re: [DISCUSS] Cleanup unreferenced statistics files through DropTableData

2025-02-27 Thread Gabor Kaszab
Thanks for the discussion on this topic during the community sync! Let me sum up what we discussed and also follow-up with some additional thoughts. *Summary:* As long as the table is there users can run orphan file cleanup to remove the orphaned stat files. If you drop the table the orphaned stat

Re: Time-based partitioning on long column type

2025-02-27 Thread Manu Zhang
Bumping this thread again. I received this SQL from a user today. CREATE TABLE partition_by_epoch_timestamp ( > `id` STRING, > `data` DECIMAL(10,0), > `start_ts` DECIMAL(10,0), > `end_ts` DECIMAL(10,0) > ) > USING iceberg > PARTITIONED BY ( > days(from_unixtime(start_ts)) > ) Of c

Re: [VOTE] Release Apache Iceberg 1.8.1 RC1

2025-02-27 Thread Alex Dutra
Hi Aihua, I just tested 1.8.1 with Polaris OSS and I am not seeing anything different. Can you share your setup? Below is my Spark setup. Thanks, Alex ./gradlew run token=$(curl -s http://localhost:8181/api/catalog/v1/oauth/tokens \ --user root: \ -d grant_type=client_credentials \ -d s