Re: guideline for interface change

2025-01-31 Thread Péter Váry
Can we deprecate the old method, and provide a default implementation for the new method using the old one? This would keep the old functionality until the deprecated method is removed. On Sat, Feb 1, 2025, 02:01 Aihua Xu wrote: > Hi folks, > > What is the general guideline for interface change

[DISCUSS] Clarify delete counts handling in partition stats

2025-01-31 Thread Anton Okolnychyi
Hi all, I propose to clarify our delete counts handling in partition stats. We have the following metrics that are marked as optional: - position_delete_record_count - position_delete_file_count - equality_delete_record_count - equality_delete_file_count If I remember correctly, the reasoning be

[VOTE] Update partition stats spec for V3

2025-01-31 Thread Anton Okolnychyi
Hi all, I propose the following updates to our partition stats spec in V3: - Modify `position_delete_record_count` to include a sum of position deletes across position delete files and DVs - Keep `position_delete_file_count` to represent the number of position delete files (ignoring DVs) - Add `d

guideline for interface change

2025-01-31 Thread Aihua Xu
Hi folks, What is the general guideline for interface change? I'm trying to change PrimitiveType Types::fromPrimitiveString() => Type Types::fromTypeString() in https://github.com/apache/iceberg/pull/11831/files#diff-736caed551a388d34b08f223954ae7ecb2fdac9d90a4098ceedd95207d7efd4dR1149-R1152 to

Re: Very strange (AI generated) issues

2025-01-31 Thread Piotr Findeisen
Extending the issue template is an option, but let's be aware of downsides and let's make sure we believe it's net positive (also outside of current situation). Some people (and bots) will overlook the checkboxes. If "I am a human" is not checked, do we auto-reject the issue? Some people will noti

Re: Very strange (AI generated) issues

2025-01-31 Thread Steve Loughran
What about extending the issue templates? Because of a growing problem with worthless LLM-generated issues, github MAY terminate any account doing this to our project [ ] I am a human being and am not creating AI generated issues. [ ] I accept that if I am posting AI-generated issues, my github ac

Re: Very strange (AI generated) issues

2025-01-31 Thread Jarek Potiuk
Hey, I am at FOSDEM now but I have some progress and more information about the whole stuf: Some facts first (without any judgment from my side): * my posts in social media reached many, many people (thanks to you - posting it and people from other foundations) - the reach out is amazing - more

Re: FileRewrite API refactor

2025-01-31 Thread Péter Váry
We could simplify the API a bit, if we omit DeleteFileRewrite. Since Anton's work around the Puffin delete vectors, this will become obsolete anyway, and focusing on data file rewriting would allow us to remove some generics from the API. WDYT? Russell Spitzer ezt írta (időpont: 2025. jan. 21.,